This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
kubernetes: dnsimple support #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ryane
commented
Apr 20, 2016
ryane
commented
- Installs cleanly on a fresh build of most recent master branch
- Upgrades cleanly from the most recent release
- Updates documentation relevant to the changes
| @@ -9,6 +9,8 @@ variable short_name {} | |||
| variable subdomain { default = "" } | |||
| variable worker_count {} | |||
| variable worker_ips {} | |||
| variable kubeworker_count {} | |||
| variable kubeworker_ips {} | |||
There was a problem hiding this comment.
should these default to 0 and "" to avoid breaking existing installations, or are we fine with that?
There was a problem hiding this comment.
yeah, good catch. updated
|
LGTM, yay for docs! 👏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.