This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Testing/local script #1382
Merged
Testing/local script #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the testing environment now manipulates a docker container, we duplicate the testing environment by simply mocking the env vars that travis uses in a locally-executed script.
In the previous version of the code, there was one try block that handled all exceptions identically. This change partitions them into logical sub-try statements, with more explicit error handling.
Since the testing environment now manipulates a docker container, we duplicate the testing environment by simply mocking the env vars that travis uses in a locally-executed script.
In the previous version of the code, there was one try block that handled all exceptions identically. This change partitions them into logical sub-try statements, with more explicit error handling.
The print function in the healthcheck.py script was trying to use UTF-8 text as ASCII text. Explicitly encoding it should fix this problem.
…to testing/local-script
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two improvements: one, it adds a local testing script that emulates our CI environment. The second is that exception handling is much better in
healthchecks.py, which is important for testing on Travis and locally. I will need to add docs for how to use the local script, so I'm leaving that checklist item in.