-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible-meraki module for Alert Settings #199
Comments
Follow up on this one. I've spent some time on this last night and lunch today. Unfortunately, getting idempotency is more challenging than I thought. I'm working through it but taking longer than I hoped. |
@richardjohnallsopp I just submitted a pull request (#204) for this. Can you give it a try and let me know what you think? Thanks. |
Yup I’ll give it go bud :-)
Richard Allsopp
Epic Games
Senior Infrastructure Engineer
Mobile +447590263111
… On 8 Oct 2020, at 21:46, Kevin Breit ***@***.***> wrote:
@richardjohnallsopp I just submitted a pull request (#204) for this. Can you give it a try and let me know what you think? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
What is the process for getting these and running them? If you could point me to some docs I'd appreciate it. |
@richardjohnallsopp There are a couple of ways to go about this. The most straight forward and simple way is to download https://raw.githubusercontent.com/kbreit/ansible-meraki/module/meraki_alert/plugins/modules/meraki_alert.py and save it locally. You should have a directory called |
Awesome, thanks man I'm off this weekend so will try all this out and report back. |
I get the following from this module:
|
Let me know if I'm doing something wrong? |
I forgot about a change to the module utility I had to do. Please download https://raw.githubusercontent.com/CiscoDevNet/ansible-meraki/2c0bc3ba5d16de222d5c8d7a032a3b9fb4ef4ec9/plugins/module_utils/network/meraki/meraki.py and put it in the |
Got it, will try and test today. |
@richardjohnallsopp Were you able to test this module? |
This one completes now, but do you have a list of names for the alert types? Also I have |
|
Hopefully I catch you while you're still working and able to test. Here is a list of alerts, which I'll add to the documentation and enforce. What type of network are you using? MX? If so, it's possible it changes the available alerts based on network type.
|
Yeah it's an MX network, but it's not setting the alert type (maybe due to the type name) and it's adding all admins regardless of the bool setting. |
I'm going to provide feedback to the API team to see if they can update documentation. Regarding where to get it, I did a query ( |
I'm looking into the all admins problem right now. |
I'll post the alerts here for anyone else that might need them:
|
Very helpful, thank you. I'm going to document these and probably enforce the values. |
@richardjohnallsopp I think I fixed the bug. It's pushed to the branch so please download the file and use the latest version. I've renamed |
It's working great:
task
|
Yup you fixed it, it all works perfectly, thanks so much for the hard work on this man!! |
@richardjohnallsopp 2.1.0 is released. Please redownload using |
I would love an ansible-meraki module to configure the alert settings for a network using this endpoint .
The text was updated successfully, but these errors were encountered: