Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DigestUtils can be mis-used to create a vulnerability #35

Open
1 task
magner669 opened this issue Apr 10, 2024 · 0 comments
Open
1 task

DigestUtils can be mis-used to create a vulnerability #35

magner669 opened this issue Apr 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@magner669
Copy link

magner669 commented Apr 10, 2024

Problem:

Tracking issue for:

A methid in the class DigestUtilsl takes string with the digest algorithm name.

The default algorithm name is sha-256 which is secure. Howver user can pass in an unsecure algorithm such as sha-1, or md5, and this might be un noticed by the tools.

Proposed solution:

Refactor to take MesageDigest object rather than the algo name.
Set the default to sha-256 as before.
Refactor call points to build and pass in MessageDigest rather than string.

This should attribute a volnerabilty to call point, and allow us to close this issue. Other scan alterts might be opened for call points which should be much easier to remidiate.

@magner669 magner669 added the enhancement New feature or request label Apr 10, 2024
@JamieSlome JamieSlome changed the title DigestUtils can be mis-used to create a volnerability DigestUtils can be mis-used to create a vulnerability Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant