Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lane highlight to Speed Limits tool #682

Closed
originalfoo opened this issue Feb 10, 2020 · 13 comments · Fixed by #709
Closed

Add lane highlight to Speed Limits tool #682

originalfoo opened this issue Feb 10, 2020 · 13 comments · Fixed by #709
Assignees
Labels
enhancement Improve existing feature Overlays Overlays, data vis, etc. SPEED LIMITS Feature: Speed limits UI User interface updates Usability Make mod easier to use
Milestone

Comments

@originalfoo
Copy link
Member

When user is hovering a speed limit icon, particularly in lane-wise mode which allows per-lane speed setting, it is sometimes unclear which lane it corresponds to.

image image

Could we pimp the relevant lane with a highlight to make it completely clear which lane is being altered?

The lane highlight would only be visible while the speed limit icon is hovered.

Suggestion: White highlight (like outgoing lanes on Lane Connector tool) but without the border -a subtle highlight might be sufficient.

@originalfoo originalfoo added enhancement Improve existing feature Usability Make mod easier to use UI User interface updates SPEED LIMITS Feature: Speed limits Overlays Overlays, data vis, etc. labels Feb 10, 2020
@originalfoo originalfoo added this to the 11.2 milestone Feb 10, 2020
@kvakvs
Copy link
Collaborator

kvakvs commented Feb 10, 2020

This might take more thinking.
I.e. those overlay signs should behave more like UI elements with the following properties:

  • Change rendering slightly when they become UI elements (optional)
  • Change color/brightness slightly when the mouse is hovered above them. Render an outline maybe.
  • Actively resist overlapping other signs, sliding away along the road segment vector if too many signs were squeezed together. Or optionally just push them apart in some cheap algorithm, and use thin lines to visually connect them to their lanes.

Now that users will perceive them as UI elements, also add the suggestion from this ticket with lane highlights.

@originalfoo
Copy link
Member Author

I find overlapping speed signs to be hugely useful timesaver - I can click overlap and update both directions at same time. I use that little trick constantly.

I think all our overlays are going to need a few iterations to improve aesthetics and usability. But for now I think just getting lane highlight solves the biggest issue of it not being overtly clear which lane/direction is being affected (especially on roads with large numbers of lanes).

@originalfoo
Copy link
Member Author

Refs: #33

@kianzarrin
Copy link
Collaborator

kianzarrin commented Feb 14, 2020

Oops I added lane highlight to parking tool by mistake!:
Screenshot (489)
Screenshot (490)

clicking enlarges the overlay turning it into orange.
Cities_c84dbkNtdr

Holding shift highlights all the lanes blue (orange if clicked). I don't know how to take a screenshot of that though. Its a nice visual feedback though.
Cities_iUl8LV1ugu

@originalfoo
Copy link
Member Author

Noce lol. I forgot that parking tool had Shift modifier to apply to route so that too will benefit from lane highlight! Keep it :)

@kianzarrin
Copy link
Collaborator

Noce lol. I forgot that parking tool had Shift modifier to apply to route so that too will benefit from lane highlight! Keep it :)

I need to add tooltip hotkey
its blocked by #701

@originalfoo
Copy link
Member Author

originalfoo commented Feb 14, 2020

I'll stash my current work on #699 and test your PRs tonight.

EDIT: Created #702 to track the lane highlight on parking tool

@kianzarrin
Copy link
Collaborator

OK this is done:
Screenshot (493)

I will take more screenshots later. shift also works, per lane also works.

PS: I might add reset functionality. I can replace the 140KMH button to reset button with del hotkey.
There is not much space on that panel. I might also multiply the size of that panel by resolution or something.

@kvakvs
Copy link
Collaborator

kvakvs commented Feb 15, 2020

Shrink icons a little and find some space, or place the button below, but please don't reduce the palette. That UI is due for rework, and the tool window will be redone.

@originalfoo
Copy link
Member Author

The speed palette has always been huge and many users complain it eats too much screen space. Related issues: #299, #573, #406.

@kianzarrin
Copy link
Collaborator

This http://www.41post.com/3816/programming/unity-scaling-the-gui-based-on-the-screen-resolution may be a solution to resolution of the GUI window.

@kvakvs
Copy link
Collaborator

kvakvs commented Feb 15, 2020

GUI resolution should be done somewhat globally in a tool class, and then applied to all GUI windows. It is out of scope of this issue.

@kianzarrin
Copy link
Collaborator

kianzarrin commented Feb 15, 2020

Screenshot (495)
Screenshot (496)

The scaling has not produced nice textures.
text fonts also need to be scaled.

I performed scaling using TrafficmangerTool.AdaptWidth/Height()

I haven't played with GUI.matrix = Matrix4x4.TRS(new Vector3(GUIsF.x,GUIsF.y,0),Quaternion.identity,GUIsF);

EDIT: I agree @kvakvs it should be a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing feature Overlays Overlays, data vis, etc. SPEED LIMITS Feature: Speed limits UI User interface updates Usability Make mod easier to use
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants