Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better AssetEditor mode detection #1286

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Better AssetEditor mode detection #1286

merged 2 commits into from
Jan 17, 2022

Conversation

krzychu124
Copy link
Member

More reliable game mode detection as FRA/FRT can switch game AppMode inside AssetEditor when grid is toggled

@krzychu124 krzychu124 added BUG Defect detected confirmed Represents confirmed issue or bug Asset Editor Issue related to TM:PE support in content editors labels Jan 16, 2022
@krzychu124 krzychu124 added this to the 11.6.0 milestone Jan 16, 2022
@krzychu124 krzychu124 self-assigned this Jan 16, 2022
originalfoo
originalfoo approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

kvakvs
kvakvs approved these changes Jan 16, 2022
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine

@krzychu124 krzychu124 merged commit adc94eb into master Jan 17, 2022
@krzychu124 krzychu124 deleted the asset-editor-game-mode-detection branch January 17, 2022 10:43
This was referenced Jan 18, 2022
Closed
Merged
@originalfoo originalfoo modified the milestones: 11.6.0, 11.6.3 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@originalfoo originalfoo originalfoo approved these changes

@kianzarrin kianzarrin kianzarrin approved these changes

@chameleon-tbn chameleon-tbn Awaiting requested review from chameleon-tbn

Assignees

@krzychu124 krzychu124

Labels
Asset Editor Issue related to TM:PE support in content editors BUG Defect detected confirmed Represents confirmed issue or bug
Projects
None yet
Milestone
11.6.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krzychu124 @kvakvs @originalfoo @kianzarrin