Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play mode detection improvement #1290

Merged
merged 4 commits into from
Jan 18, 2022
Merged

Play mode detection improvement #1290

merged 4 commits into from
Jan 18, 2022

Conversation

krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Jan 18, 2022 •
edited

Related #1286 - one scene was not enough for all cases
Closes #1289

Build zip

@krzychu124 krzychu124 added confirmed Represents confirmed issue or bug Asset Editor Issue related to TM:PE support in content editors regression old bug comes back or a new bug introduced in code that used to work. labels Jan 18, 2022
@krzychu124 krzychu124 added this to the 11.6.0 milestone Jan 18, 2022
@krzychu124 krzychu124 self-assigned this Jan 18, 2022
kvakvs
kvakvs approved these changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

originalfoo
originalfoo approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
image

@krzychu124 krzychu124 mentioned this pull request Jan 18, 2022
Closed
1 task
chameleon-tbn
chameleon-tbn approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@krzychu124 krzychu124 merged commit 03491e7 into master Jan 18, 2022
@krzychu124 krzychu124 deleted the 1289-play-mode-detection-fix branch January 18, 2022 13:46
@originalfoo originalfoo modified the milestones: 11.6.0, 11.6.3 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@originalfoo originalfoo originalfoo approved these changes

@chameleon-tbn chameleon-tbn chameleon-tbn approved these changes

Assignees

@krzychu124 krzychu124

Labels
Asset Editor Issue related to TM:PE support in content editors confirmed Represents confirmed issue or bug regression old bug comes back or a new bug introduced in code that used to work.
Projects
None yet
Milestone
11.6.3
Development

Successfully merging this pull request may close these issues.

Despawn vehicle button missing
4 participants
@krzychu124 @kvakvs @originalfoo @chameleon-tbn