What's New 11.6.4.1 #1317
What's New 11.6.4.1 #1317
Conversation
Not really, we can't reproduce the problem (me & Kian). No idea what happened. I forgot to test with IMT and NCR, maybe that combination in Asset Editor also result in weird errors, similarly to previous issues with copy&pasting 🤷♂️ |
|
Could you also check if links are correct. I'm not 100% but I think I saw missing 0 -> links to 11.6.4 instead of 11.6.4.0 so anchor does not work correctly |
|
@krzychu124 done - every release now has tested working link |
|
Hmm it opens every time I click on the TM:PE main menu 🤔 |
TLM/TLM/UI/WhatsNew/WhatsNew.cs
Outdated
| @@ -11,7 +11,7 @@ namespace TrafficManager.UI.WhatsNew { | |||
|
|
|||
| public class WhatsNew { | |||
| // bump and update what's new changelogs when new features added | |||
| internal static readonly Version CurrentVersion = new Version(11, 6, 4, 0); | |||
| internal static readonly Version CurrentVersion = new Version(11,6,4,1); | |||
|
|
|||
| internal static readonly Version PreviouslySeenVersion = GlobalConfig.Instance.Main.LastWhatsNewPanelVersion; | |||
There was a problem hiding this comment.
This cannot be readonly because MarkAsShown won't work properly
There was a problem hiding this comment.
Wait, it's always been that way - here's the original version of the class: 7cd4a30#diff-fa2814c9d64acf4ea7741ee6d806ae2e559b946734217b0c5ad1f0d50566385eR22
Also, why won't MarkAsShown() work? It only updates global config, and the value of that is accessed via PreviouslySeenVersion (which could arguably be a getter/setter tbh)
When global config is loaded, is it trying to update something in WhatsNew.cs?
There was a problem hiding this comment.
Maybe it's the Shown getter that was causing problem. I assume you were seeing it every time when opening TM:PE panel?
will send commit shortly
There was a problem hiding this comment.
I'm talking about PreviouslySeenVersion -> once mod is initialized it will never change its value so even if you call MarkAsShown(). Yes, to check if we should show we use Shown, but now it returns always the same value no matter if you haven't seen it and the later opened
There was a problem hiding this comment.
@krzychu124 I've just pushed a commit to this PR that should fix it - haven't had time to test it in-game myself yet (will be another 30-45 mins before I get chance to do that)
WhatsNew.csand update the UI #1319 What's New 11.6.4.1 #1317StackOverflowException-WhatsNewPanel.cs#1314 (aubergine18)