Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed limit overlay signs not visible on train tracks #1318

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Speed limit overlay signs not visible on train tracks #1318

merged 1 commit into from
Jan 26, 2022

Conversation

krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Jan 25, 2022 •
edited

Speed limit overlay signs not visible on train tracks due to bug introduced in one of improvements 馃槙

Build zip

@krzychu124 krzychu124 added LABS TM:PE LABS branch STABLE TM:PE STABLE branch SPEED LIMITS Feature: Speed limits regression old bug comes back or a new bug introduced in code that used to work. labels Jan 25, 2022
@krzychu124 krzychu124 added this to the 11.6.4-hotfix-1 milestone Jan 25, 2022
@krzychu124 krzychu124 self-assigned this Jan 25, 2022
kvakvs
kvakvs approved these changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy, oh boy

originalfoo added a commit that referenced this pull request Jan 26, 2022
@originalfoo
Add #1318 to changelogs
2470fe7
@originalfoo originalfoo mentioned this pull request Jan 26, 2022
Merged
originalfoo
originalfoo approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built from source as RELEASE, tested ingame, tracks have speed limits again :)

@krzychu124 krzychu124 merged commit d3e0e23 into master Jan 26, 2022
@krzychu124 krzychu124 deleted the speed-limits-not-visible-on-train-tracks branch January 26, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@originalfoo originalfoo originalfoo approved these changes

@kianzarrin kianzarrin kianzarrin approved these changes

@chameleon-tbn chameleon-tbn Awaiting requested review from chameleon-tbn

Assignees

@krzychu124 krzychu124

Labels
LABS TM:PE LABS branch regression old bug comes back or a new bug introduced in code that used to work. SPEED LIMITS Feature: Speed limits STABLE TM:PE STABLE branch
Projects
None yet
Milestone
11.6.4-hotfix-1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krzychu124 @kvakvs @originalfoo @kianzarrin