Catch + log any load/save errors in OptionsManager
#1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
originalfoo
added
the
technical
originalfoo
added
high priority
krzychu124
approved these changes
Feb 2, 2022
originalfoo
added a commit
that referenced
this pull request
Feb 2, 2022
This release makes some refinements to error checking/logging, and refines the pathfinder edition check/warning. - [Meta] TM:PE 11.6.4-hotfix-5 - [Meta] Updates to error checking/logging, and refine pathfinder edition checks - [Updated] Catch and log errors in savegame options save/load #1345 (aubergine18) - [Updated] Pathfinder edition check refinements #1347 (aubergine18) - [Updated] Reduce severity of some normal log messages #1348 #1350 (aubergine18)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap contents of the load/save data methods in
try...catchblocks, logging any errors that may occur so at least we can find out where it went wrong.When saving, I've set it to return the
savebyte arrray as that way we should be able to salvage most of the options (assuming the most common issue will be forgetting to update the size of the array when new options are added). Not sure if this is good or bad idea, lmk in comments.