Refactor remainder of `Policies` tab groups #1455

originalfoo · 2022-03-04T05:21:34Z

Compiled mod for testing: TMPE.zip

Part of ongoing work on #1356 phase 2.

Notably, this ensures options propagate to features they require (eg. setting parking ban on roundabouts will enable parking restrictions feature)
Fixes: Multiple users report roundabout quick-setup not working #1429

This completes phase 2 refactor of all mod options groups.

Closes: #62

TLM/TLM/Manager/Impl/OptionsManager.cs

krzychu124

Works in game without any noticeable issues 👍

kvakvs

Questioning why Propagate*To can fail

kvakvs · 2022-03-05T08:10:03Z

TLM/TLM/State/OptionsTabs/PoliciesTab_InEmergenciesGroup.cs

+            => SteamHelper.IsDLCOwned(SteamHelper.DLC.NaturalDisastersDLC);
+
+        internal static void AddUI(UIHelperBase tab) {
+            if (!HasNaturalDisastersDLC) return;


Would it be a good idea to show the group caption at all times, but then if DLC is not owned, add a text label explaining that a DLC is required?

Yes, I'm thinking of doing that in later iteration once I add some more UI components.

kvakvs · 2022-03-05T08:11:15Z

TLM/TLM/State/OptionsTabs/PoliciesTab_InEmergenciesGroup.cs

+            EvacBussesMayIgnoreRules.AddUI(group);
+        }
+
+        private static bool NaturalDisastersDlcValidator(bool desired, out bool result) {


Why this exists? Confusing function: updates some out variable and returns true? Move the logic to the caller.

It's just a guard in central location at the moment. I'll probably change that in 11.6.5.2 branch but depends on how things go with converting Options to instance-based.

kvakvs · 2022-03-05T08:13:22Z

TLM/TLM/State/OptionsTabs/PoliciesTab_OnRoadsGroup.cs

+        private static UIDropDown _vehicleRestrictionsAggressionDropDown;
+
+        static PoliciesTab_OnRoadsGroup() {
+            try {


Why this can fail? It should never fail in my opinion.

Krzychu made same comment recently. The reason I do it is because if anything goes wrong in a static constructor it causes cascading failure in C:SL which does not guard against that eventuality. That in turn results in user's game config file being wiped, all mods are then disabled, paradox account reset, etc.

Errors are most likely to creep in during dev and test phase - while they will obviously get fixed it's a complete PITA to have to re-enable 140 mods, espeically when some mods (Ambient Sounds Tuner in particular) need enabling last to prevent further settings loss. So the try..catch is really just to protect myself from my own stupid bugs during dev & test :)

TLM/TLM/State/OptionsTabs/PoliciesTab_PriorityRoadsGroup.cs

kianzarrin · 2022-03-12T15:24:50Z

TLM/TLM/Util/RoundaboutMassEdit.cs

@@ -121,14 +121,14 @@ public class RoundaboutMassEdit {
        }

        private static void FixRulesRoundabout(ushort segmentId, bool startNode) {
-            if (OptionsMassEditTab.RoundAboutQuickFix_PrioritySigns) {
+            if (Options.RoundAboutQuickFix_PrioritySigns) {


why this change? performance?

Yup, but just as an interim measure (eg. as you mentioned in another PR, harmony could be used to remove the reflection bottleneck).

For now my main goal is just to get everything in options as consistent as possible. In next stage I'm seeking to make the options fields instance-based; currently they are static. Once instance-based, it will be appropriate to define defaults at the field level (currently defaults are being set in OptionsManager.LoadData() as an interim workaround for static fields in Options.cs), and there will be a whole bunch of other changes.

kianzarrin · 2022-03-12T15:33:48Z

Path of evil is default value in new game. is this expected? I remember it used to be minor complaints.

kianzarrin · 2022-03-12T15:35:27Z

Also "vehicles going straight on can change lane on junctions" is on by default. Isn't that illegal in the real world?

originalfoo · 2022-03-12T16:46:58Z

Path of evil is default value in new game. is this expected? I remember it used to be minor complaints.

Good catch!

Looking at Options.cs before I started altering stuff:

TMPE/TLM/TLM/State/Options.cs

Line 30 in 23ee4b2

public static int recklessDrivers = 3;

new[] {
    Translation.Options.Get("Gameplay.Dropdown.Option:Path Of Evil (10%)"), // 0 
    Translation.Options.Get("Gameplay.Dropdown.Option:Rush Hour (5%)"), // 1
    Translation.Options.Get("Gameplay.Dropdown.Option:Minor Complaints (2%)"), // 2
    Translation.Options.Get("Gameplay.Dropdown.Option:Holy City (0%)"), // 3
},

So yeah, should be Holy City (0%). Will send commit to fix.

Also "vehicles going straight on can change lane on junctions" is on by default. Isn't that illegal in the real world?

Another good catch! Should be off by default, will update in next commit.

originalfoo · 2022-03-12T17:32:07Z

@kianzarrin Fixed bugs you spotted.

originalfoo · 2022-03-12T19:50:49Z

@kvakvs Is there any changes you specifically want in this PR or can comments above be left until next phase of updates to options stuff?

kvakvs

I read the code diff earlier. Its fine

kianzarrin · 2022-03-12T22:18:16Z

I checked WS TMPE and this build and found more differences. Not sure if its withing the scope of this PR.

Individual driving style used to be on by default
buses may ignore lane arrows used to be off by default

Old values in new game:

originalfoo · 2022-03-12T22:21:46Z

urg, 1 sec, will send PR to fix

originalfoo · 2022-03-12T22:26:05Z

buses may ignore lane arrows used to be off by default

Yeah, that was causing constant trickle of support so it was changed in this PR.

Can change it back to off by default if desired. @krzychu124 what do you think?

Refactor remainder of policies tab groups

e9d0ce8

originalfoo added UI User interface updates code cleanup Refactor code, remove old code, improve maintainability Settings Road config, mod options, config xml labels Mar 4, 2022

originalfoo added this to the 11.6.5.1 milestone Mar 4, 2022

originalfoo requested review from kvakvs, DaEgi01 and kianzarrin March 4, 2022 05:21

originalfoo self-assigned this Mar 4, 2022

originalfoo changed the title ~~Refactor remainder of policies tab groups~~ Refactor remainder of Policies tab groups Mar 4, 2022

Merge branch 'master' into refactor-policies-tab-groups

1e8ce57

originalfoo mentioned this pull request Mar 4, 2022

RFI: Updates to mod options tabs #1356

Open

4 tasks

Remove unnecessary usings

b33afb8

originalfoo mentioned this pull request Mar 4, 2022

Multiple users report roundabout quick-setup not working #1429

Closed

Merge branch 'master' into refactor-policies-tab-groups

c676681

originalfoo mentioned this pull request Mar 5, 2022

Translations for 11.6.5 (localisation / locale / crowdin) #1344

Closed

9 tasks

krzychu124 reviewed Mar 5, 2022

View reviewed changes

TLM/TLM/Manager/Impl/OptionsManager.cs Show resolved Hide resolved

Merge branch 'master' into refactor-policies-tab-groups

4a2a543

krzychu124 approved these changes Mar 5, 2022

View reviewed changes

kvakvs requested changes Mar 5, 2022

View reviewed changes

originalfoo added 2 commits March 5, 2022 22:28

Merge branch 'master' into refactor-policies-tab-groups

6d8e750

Merge branch 'master' into refactor-policies-tab-groups

47d65b9

originalfoo mentioned this pull request Mar 12, 2022

What's New in TM:PE 11.6.5.1 ? #1433

Merged

kianzarrin reviewed Mar 12, 2022

View reviewed changes

Merge branch 'master' into refactor-policies-tab-groups

d2970d2

Fix bugs discovered by Kian

0d2f593

kvakvs approved these changes Mar 12, 2022

View reviewed changes

originalfoo merged commit 02e8fe2 into master Mar 12, 2022

originalfoo deleted the refactor-policies-tab-groups branch March 12, 2022 22:15

originalfoo mentioned this pull request Mar 12, 2022

Ensure defaults set correctly - fix regressions #1464

Merged

originalfoo mentioned this pull request Apr 4, 2022

Quick set-up for high priority roundabout does not work. (CTRL+SHIFT+CLICK) #1494

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor remainder of `Policies` tab groups #1455

Refactor remainder of `Policies` tab groups #1455

originalfoo commented Mar 4, 2022 •

edited

krzychu124 left a comment

kvakvs left a comment

kvakvs Mar 5, 2022

originalfoo Mar 5, 2022

kvakvs Mar 5, 2022

originalfoo Mar 5, 2022

kvakvs Mar 5, 2022

originalfoo Mar 5, 2022

kianzarrin Mar 12, 2022 •

edited

originalfoo Mar 12, 2022

kianzarrin commented Mar 12, 2022

kianzarrin commented Mar 12, 2022

originalfoo commented Mar 12, 2022 •

edited

originalfoo commented Mar 12, 2022

originalfoo commented Mar 12, 2022

kvakvs left a comment

kianzarrin commented Mar 12, 2022 •

edited

originalfoo commented Mar 12, 2022

originalfoo commented Mar 12, 2022

Refactor remainder of Policies tab groups #1455

Refactor remainder of Policies tab groups #1455

Conversation

originalfoo commented Mar 4, 2022 • edited

krzychu124 left a comment

Choose a reason for hiding this comment

kvakvs left a comment

Choose a reason for hiding this comment

kvakvs Mar 5, 2022

Choose a reason for hiding this comment

originalfoo Mar 5, 2022

Choose a reason for hiding this comment

kvakvs Mar 5, 2022

Choose a reason for hiding this comment

originalfoo Mar 5, 2022

Choose a reason for hiding this comment

kvakvs Mar 5, 2022

Choose a reason for hiding this comment

originalfoo Mar 5, 2022

Choose a reason for hiding this comment

kianzarrin Mar 12, 2022 • edited

Choose a reason for hiding this comment

originalfoo Mar 12, 2022

Choose a reason for hiding this comment

kianzarrin commented Mar 12, 2022

kianzarrin commented Mar 12, 2022

originalfoo commented Mar 12, 2022 • edited

originalfoo commented Mar 12, 2022

originalfoo commented Mar 12, 2022

kvakvs left a comment

Choose a reason for hiding this comment

kianzarrin commented Mar 12, 2022 • edited

originalfoo commented Mar 12, 2022

originalfoo commented Mar 12, 2022

Refactor remainder of `Policies` tab groups #1455

Refactor remainder of `Policies` tab groups #1455

originalfoo commented Mar 4, 2022 •

edited

kianzarrin Mar 12, 2022 •

edited

originalfoo commented Mar 12, 2022 •

edited

kianzarrin commented Mar 12, 2022 •

edited