-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure defaults set correctly - fix regressions #1464
Conversation
These would get overwritten during deserialization so they had no effect anyway. Removing to clarify that.
public static bool individualDrivingStyle = true; | ||
public static int recklessDrivers = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aubergine10 is this a result of recent changes? Warning 3.9198840: Skipping invalid value 1 for vehicle restrictions aggression
at CSUtil.Commons.Log.LogToFile(System.String log, LogLevel level)
at CSUtil.Commons.Log.Warning(System.String s)
at TrafficManager.Manager.Impl.OptionsManager.LoadData(System.Byte[] data)
at TrafficManager.Lifecycle.SerializableDataExtension.Load()
at TrafficManager.Lifecycle.TMPELifecycle.Awake()
at UnityEngine.GameObject.Internal_AddComponentWithType(System.Type )
at UnityEngine.GameObject.AddComponent(System.Type componentType)
at UnityEngine.GameObject..ctor(System.String name, System.Type[] components)
at TrafficManager.Lifecycle.TMPELifecycle.StartMod()
at TrafficManager.Lifecycle.TrafficManagerMod.OnEnabled()
at System.Reflection.MonoMethod.InternalInvoke(System.Object , System.Object[] , System.Exception ByRef )
at System.Reflection.MonoMethod.Invoke(System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture)
at System.Reflection.MethodBase.Invoke(System.Object obj, System.Object[] parameters)
at ColossalFramework.Plugins.PluginManager.AddPlugins(System.Collections.Generic.Dictionary`2 plugins)
at ColossalFramework.Plugins.PluginManager.LoadPluginAtPath(System.String path, Boolean builtin, PublishedFileId id)
at ColossalFramework.Plugins.PluginManager.OnPluginAdded(System.String path)
at ColossalFramework.Plugins.PluginManager+<>c__DisplayClass20.<OnFileWatcherEventChanged>b__1a()
at ColossalFramework.Threading.Dispatcher+<>c__DisplayClass4.<CreateSafeAction>b__3()
at ColossalFramework.Threading.Task`1+<>c__DisplayClassa[[ColossalFramework.Threading.Task+VoidTask, ColossalManaged, Version=0.3.0.0, Culture=neutral, PublicKeyToken=null]].<.ctor>b__8(ColossalFramework.Threading.Task t)
at ColossalFramework.Threading.Task`1[[ColossalFramework.Threading.Task+VoidTask, ColossalManaged, Version=0.3.0.0, Culture=neutral, PublicKeyToken=null]].Execute()
at ColossalFramework.Threading.Task.InternalExecute()
at ColossalFramework.Threading.Dispatcher.RunTask(ColossalFramework.Threading.Task task)
at ColossalFramework.Threading.Dispatcher.ProcessSingleTask(ColossalFramework.Threading.Task task)
at ColossalFramework.Threading.Dispatcher.InternalProcessTasks()
at ColossalFramework.Threading.Dispatcher.ProcessTasks()
at ColossalFramework.Threading.ThreadHelper.FpsBoosterUpdate()
at BehaviourUpdater.Updater.Update() |
@krzychu124 It's possible, ofc, but I didn't get any errors while testing during recent PRs.
|
Kian noticed some issues in earlier PR regarding mod option defaults.
#1455 (comment)
Notably:
on
by defaultoff
by defaultThis PR fixes the first (driving styles) but leaves the second (bus ingore lane arrows) as defaulting to
on
- currently. Should I change bus ignore arrows back tooff
by default, or should it beon
by default? It's trivial to change either way.I also explicitly defined several
false
defaults in the options manager.