-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Function to Disable & Remove Traffic Lights #390
Conversation
Hi - sorry for delay in responding, we're currently gearing up for 10.21 release so things are a bit hectic - please bear with us, and thanks for the contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just tested your PR.
Everything is working great 😃
Let's see what others think, but personally I would move Clear Traffic Lights
button to Maintenance tab. It a better place for that, I think 😉
First I had the "Remove All Traffic Lights" button in Maintenance too (because @Sqoops put it there in #320). But the other options in Maintenance are just cleanup and don't alter the map forever, while "Remove All Lights" is quite radical and directly changes how traffic flows. That's why I added an additional confirmation dialog and moved it into the "Gameplay" Tab. But of course I can move it back. (And in terms of layout the button would fit better into the list of other buttons than between tiny toggles ;) ) |
For now stick it on maintenance tab. I think at some point we'll have to rethink the mod options screen as it's getting very crowded. |
Existing junctions are not touched. Existing junctions with lights keep their lights when updated (like new road into the junction).
882361b
to
aa70e0c
Compare
Totally forgot about that PR. 🤦♂ |
…icts, changed manual detour to harmony postfix, adopted translations
Button to remove / disable all traffic lights
Adds a new junctions settings group under "Gameplay" to:
Fixes #320