Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Function to Disable & Remove Traffic Lights #390

Closed
wants to merge 6 commits into from

Conversation

Craxy
Copy link

@Craxy Craxy commented Jun 23, 2019

Button to remove / disable all traffic lights

Adds a new junctions settings group under "Gameplay" to:

  • disable traffic lights at new junctions
    • touches only new junctions, not existing ones
    • still allows adding lights manually -- it only prevents lights at new junctions
  • remove all traffic lights at existing junctions
    • doesn't remove timed traffic lights
    • because quite drastic and undoable: confirmation dialog before execution

Fixes #320

@FireController1847 FireController1847 changed the title Implement #320: Remove/disable all traffic lights Add Function to Disable & Remove Traffic Lights Jun 23, 2019
@FireController1847 FireController1847 added enhancement Improve existing feature feature A new distinct feature LABS TM:PE LABS branch STABLE TM:PE STABLE branch labels Jun 23, 2019
@FireController1847 FireController1847 modified the milestones: 11.0, 11.1 Jun 23, 2019
@originalfoo originalfoo added UI User interface updates Usability Make mod easier to use Localisation Localised text and features labels Jun 26, 2019
@originalfoo originalfoo self-requested a review June 26, 2019 01:57
@krzychu124 krzychu124 self-assigned this Jun 26, 2019
@originalfoo
Copy link
Member

Hi - sorry for delay in responding, we're currently gearing up for 10.21 release so things are a bit hectic - please bear with us, and thanks for the contribution!

Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just tested your PR.
Everything is working great 😃
Let's see what others think, but personally I would move Clear Traffic Lights button to Maintenance tab. It a better place for that, I think 😉

@Craxy
Copy link
Author

Craxy commented Jul 1, 2019

First I had the "Remove All Traffic Lights" button in Maintenance too (because @Sqoops put it there in #320). But the other options in Maintenance are just cleanup and don't alter the map forever, while "Remove All Lights" is quite radical and directly changes how traffic flows. That's why I added an additional confirmation dialog and moved it into the "Gameplay" Tab.

But of course I can move it back. (And in terms of layout the button would fit better into the list of other buttons than between tiny toggles ;) )

@originalfoo
Copy link
Member

For now stick it on maintenance tab. I think at some point we'll have to rethink the mod options screen as it's getting very crowded.

@originalfoo originalfoo modified the milestones: 11.1, 11.0 Aug 6, 2019
@FireController1847 FireController1847 removed their request for review August 12, 2019 01:33
@originalfoo originalfoo added the TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc label Aug 13, 2019
@krzychu124
Copy link
Member

Totally forgot about that PR. 🤦‍♂
I will create new PR and I'll move your work you've done here, because resolving conflicts in this branch is waste of time, since it's pre-Harmony version and translation system has changed after moving to CrowdIn platform.

@krzychu124 krzychu124 closed this Oct 21, 2019
krzychu124 added a commit that referenced this pull request Oct 21, 2019
…icts, changed manual detour to harmony postfix, adopted translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing feature feature A new distinct feature LABS TM:PE LABS branch Localisation Localised text and features STABLE TM:PE STABLE branch TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc UI User interface updates Usability Make mod easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button to remove / disable all traffic lights
4 participants