Function to Disable & Remove Traffic Lights

[krzychu124]

Fixes #320

Description:

• disable traffic lights at new junctions
  • touches only new junctions, not existing ones
  • still allows adding lights manually -- it only prevents lights at new junctions
• remove all traffic lights at existing junctions
  • doesn't remove timed traffic lights
  • because quite drastic and undoable: confirmation dialog before execution

Additional work done:

• moved implementation made by @Craxy from closed PR(Add Function to Disable & Remove Traffic Lights #390).
• changed manual detour to harmony postfix,
• adapted translations to new translation system (new keys have to be added to Crowdin) Done

[originalfoo]

Looks like it will need translations adding to options.csv for following keys:

Policies tab:

• VR.Checkbox:Disable setting up traffic lights for new junctions -- @VictorPhilipp once mentioned to me it's best to avoid 'negative' options, so this might be better as VR.Checkbox:Automatically add traffic lights if applicable (and default the setting to true)?

Maintenance tab:

• Maintenance.Button:Remove all existing traffic lights

Not sure about following keys - @kvakvs any suggestions?

• Maintenance.Dialog.Title:Remove all traffic lights
• Maintenance.Dialog.Text:Remove all traffic lights, Confirmation

[krzychu124]

Right, we have to add those keys.
Text is not final because I wasn't sure how it should look like, (Dialog.Text keys)
I forgot about negative option suggestion. I'd got 'false' as default value in my mind while I wrote that checkbox key text 😅 I like your suggested description.

[kvakvs]

2 notes, but only 1 action required.
Otherwise looking good

[krzychu124]

I've just benchmarked Remove traffic lights call and I must say it's not that bad. On my potato laptop, 30-35 ms, savegame with 650k population city