Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD Panel and Keybinds as a separate library #500

Closed
wants to merge 1 commit into from

Conversation

kvakvs
Copy link
Collaborator

@kvakvs kvakvs commented Aug 24, 2019

Creates a library which provides OSD panel and keybinds to the application. The panel can be reused by multiple copies of UXLibrary running in different mods. Now delivered as a part of TM:PE but does not depend on TM:PE code, and can be extracted into a separate library.

Closes #410
Closes #437

  • Panel can be dragged
  • An option or a button to show & hide
  • Position and visibility are saved in a configuration file
  • Integrate with tools
    • Integrate with Lane Arrows
    • Integrate with Lane connectors
    • Integrate with Traffic Lights
    • Integrate with Junction Restrictions
    • Integrate with Parking Restrictions
    • Integrate with Vehicle Restrictions
  • Move keybinds options panel code into the UX Library too
  • Keybinds are saved in another configuration file (Separate from position and visibility)
  • Keybinds are more compact (replace Primary Mouse Button with for example Mouse1) - this one is a problem because Translate namespace is not available without using TLM.UI.Translation
  • Translations

image
image

@originalfoo originalfoo added UI User interface updates Usability Make mod easier to use labels Aug 24, 2019
@originalfoo
Copy link
Member

I'd avoid integration with traffic lights for now - probably better to wait until we overhaul that feature. Also, the on-screen panel in timed traffic lights already gives fairly decent guidance on what to do.

Regarding more compact keybinds, particularly the mouse buttons, could we use icons? Something like:

img

or

img

@originalfoo
Copy link
Member

Also, I don't think we should save keybinds in save game. They should be stored globally only.

Otherwise if we get save games from users to bugfix, we'd be stuck with their keybinds. It would also be a PITA to have save-specific keybinds as you'd never be quite sure what keybinds are active as they could change from save to save.

@originalfoo
Copy link
Member

Can this PR be closed as the OSD is being implemented via #819

@kvakvs kvakvs closed this Apr 12, 2020
@originalfoo originalfoo added this to the 11.5.0 milestone Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User interface updates Usability Make mod easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Keybind code to UI namespace On-screen display mod
2 participants