Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further enhancements to menu tooltips/keybinds #720

Closed
originalfoo opened this issue Feb 20, 2020 · 5 comments · Fixed by #868
Closed

Further enhancements to menu tooltips/keybinds #720

originalfoo opened this issue Feb 20, 2020 · 5 comments · Fixed by #868
Labels
Accessibility Color blindness, etc. DESPAWN TOOLS Feature: Clear traffic, toggle despawn, vehicle/parked/cim despawns enhancement Improve existing feature Localisation Localised text and features PRIORITY SIGNS Feature: Stop / Yield / Priority signs Settings Road config, mod options, config xml UI User interface updates Usability Make mod easier to use VEHICLE RESTRICTIONS Feature: Vehicle restrictions
Milestone

Comments

@originalfoo
Copy link
Member

originalfoo commented Feb 20, 2020

While testing #656 I noticed some issues with tooltips and keybinds, I think maybe a separate PR could imrpove things a little if time permits...

I just added a keybind to Parking Restrictions for first time and got this:

image

Also, I think we should change where tool-select keybind is shown, if that's possible? For example, this is what Priority Signs tooltip currently looks like:

image

It's difficult to see clearly what is going on there.

I would suggest cleaning it to something like:

Priority Signs (Shift + P)

When tool is active, you can:
Shift+Click: ...
Ctrl+Click: ...
Ctrl+Shift+Click: ...

Also, is it possible to have keybind (ie, the shortcut key strings, not their effect) in different colour such as yellow?

Following tools are still missing keybinds:

  • Timed Traffic Lights and Manual Traffic Lights
    • I hope we can one day merge all traffic lights in to one completely refactored tool
    • So ignore these for now
  • Disable Despawning
    • Keybind would toggle state
  • Vehicle Restrictions
  • Clear Traffic
    • Doesn't need a keybind IMO
@originalfoo originalfoo added enhancement Improve existing feature Usability Make mod easier to use Localisation Localised text and features Accessibility Color blindness, etc. UI User interface updates DESPAWN TOOLS Feature: Clear traffic, toggle despawn, vehicle/parked/cim despawns VEHICLE RESTRICTIONS Feature: Vehicle restrictions PRIORITY SIGNS Feature: Stop / Yield / Priority signs Settings Road config, mod options, config xml labels Feb 20, 2020
@krzychu124
Copy link
Member

Also, is it possible to have keybind (ie, the shortcut key strings, not their effect) in different colour such as yellow?

Only when we separate keybind from actual translation. I mentioned about that somewhere (github/discord), don't remember.

With current implementation we can't really change keybind without additional help of translators (you have to alter all languages), not to mention that translation string change is pretty hard to spot.
I couldn't find a good way to notify other translators about change, because notifications works only for new strings/languages.

I would love to see OSD in action instead of boring tooltips 😄

@originalfoo
Copy link
Member Author

Another feedback, the left/right padding on tooltips seems overly huge:

image

@kvakvs
Copy link
Collaborator

kvakvs commented Feb 20, 2020

@kianzarrin there was this #500
and this #421
I will need to take pieces of that work, plus create compact buttons icons, and we'll be good on keybinds.

@originalfoo originalfoo mentioned this issue Feb 24, 2020
@originalfoo originalfoo added this to the 11.5.0 milestone Apr 28, 2020
@originalfoo
Copy link
Member Author

Excluding additional keybinds, #868 fixes this issue #720. Additional keybinds stuff can get added when individual tools are updated in future PRs.

@originalfoo
Copy link
Member Author

doh

@originalfoo originalfoo reopened this Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Color blindness, etc. DESPAWN TOOLS Feature: Clear traffic, toggle despawn, vehicle/parked/cim despawns enhancement Improve existing feature Localisation Localised text and features PRIORITY SIGNS Feature: Stop / Yield / Priority signs Settings Road config, mod options, config xml UI User interface updates Usability Make mod easier to use VEHICLE RESTRICTIONS Feature: Vehicle restrictions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants