Mass-edit road selection panel

[kianzarrin]

fixes #542

I was unable to fully fix mass edit overlay so I disabled it and created issue #789
I fixed all other problems.
This is ready for review.

Added Identical road selection UI to roadAdjust panel and roadWorldInfoPanel. See #542 (comment) for pictures.

expected behavior

• Both panels trigger tutorial message (same).
• activation of the panel in roadAdjust activates mass edit overlay so that user can see relevant traffic rules. same is true when user clicks a button. note that roadAdjust is in turn automatically activated when user tries to modify road selection.
• clicking a button will apply traffic rules and puts it in active state. clicking it again deactivates it and clears relevant traffic rules. Clear does not have undo mode.

Scope:

Since there is so much new user interface here there is a lot of potential for new feature [EDIT: see #691]. Therefore I have to severely limit the scope of this review by limiting some of the functionality. The objective is not to implement all missing features in TMPE! Its to provide the base UI interface and lay out the foundation for the rest of the work.
EDIT: speaking of scope priority roads that turn on junctions are not supported. Roundabout paths on the other hand can go through different routes.
EDIT: paths that turn left/right on junctions are supported.

further changes

• Road selection util is an interface that exposes the list of selected segments. Also it provides an event that is invoked whenever selection changes. EDIT: in future we may need to promote to manger in order to serialize intents see Priority road UI discussion #691
• Linear sprite button now has an optional disabled state.
• implemented simplistic undo functionality for roundabout. (I worked around managers should provide reset functions for traffic rules. #623) EDIT: with managers should provide reset functions for traffic rules. #623 resolved, I am able to clear traffic rules (its more basic than restore/undo see Undo/delete feature #568)
• I moved the code to put priority signs responding to shift-click from PrioirtySingsTool.cs into PrioirtyRoad.cs . I modified it so that it I can use it by my road selection panel.

Translation keys:

These keys have been added in another PR.:

Menu.csv
"RoadSelection.Tooltip:Clear"=>"Clear traffic rules related to high priority road" // for now!
"RoadSelection.Tooltip:Stop entry"=>"applies stop signs on connected roads"
"RoadSelection.Tooltip:Yield entry"=>"applies Yield signs on connected roads"
"RoadSelection.Tooltip:High priority"=>"Applies traffic rules for high priority road(customizable in options)"
"RoadSelection.Tooltip:Roundabout"=>"applies all traffic rules for roundabout. button is disabled when selection is not a roundabout."

tutorial.csv
"TMPE_TUTORIAL_BODY_RoadSelection"=>"   Clicking each of the buttons(except the clear button) applies traffic rules. clicking the same button again clears those traffic rules. Each button is enabled only when there is a valid selection of road/roundabout.\n\n   To select a road, click on the green road selection button."
"TMPE_TUTORIAL_HEAD_RoadSelection"=>"TM:PE Mass-edit Road Selection Panel"

[kianzarrin]

I fixed a couple of problems please see commit message.

[originalfoo]

LGTM 👍

[kianzarrin]

@krzychu124 Edit:
While menu is visible I'm noticing significant fps drop ~15-20ms/frame in my case, so from 30fps it drops to ~20fps
only TM:PE subscribed and enabled

I cannot reproduce this problem

You didn't answer this. I take it that this is OK by now?

[kianzarrin]

@krzychu124 I made a few lines of simple changes. Can you please approve this.

[originalfoo]

Regarding the performance issue while tmpe toolbar is open, like Kian I also don't see any drop in frame rate. Could be hardware specific though.

[krzychu124]

Regarding the performance issue while tmpe toolbar is open, like Kian I also don't see any drop in frame rate. Could be hardware specific though.

Fps drop was caused by excessive log spam.

[krzychu124]

The following questions are still without answers nor even comment (yes/no)
I'm not really perfectionist but I see possible bugs/typos and I'm not sure if they were intent(I can't read in minds, sorry).

[kianzarrin]

I'm not really perfectionist but I see possible bugs/typos and I'm not sure if they were intent(I can't read in minds, sorry).

You are absolutely right!

The following questions are still without answers nor even comment (yes/no)

@krzychu124 this is github being stupid. I did put comments but it does not show up in the conversation tab. you should go to the files changed tab to see the comments I put in the files changed tab. Can you please do that and respond to me?

[kianzarrin]

@krzychu124 one more thing. Sometimes you have to press Load Diff for big files otherwise you might not see the comments.

[originalfoo]