Onscreen Hints for more tools

[kvakvs]

Fixes: #720

• Should be fixing the ominous null UIView problem when UI components are deactivated by SetActive(false) and beheaded by DetachChildren in their parent
• Junction Restrictions tool
  • Strings: JunctionRestrictions.csv: "OnscreenHint.Mode:Select", "OnscreenHint.Reset:Reset to default" (or reuse from LaneRouting.csv "LaneConnector.Label:Reset to default")
• Manual Traffic Lights tool
  • Strings: TrafficLights.csv: "ManualTL.Mode:Select", "ManualTL.Mode:Edit"
• Priority Signs tool
  • Strings: PrioritySigns.csv: "OnscreenHint.Mode:Select", "OnscreenHint.Mode:Edit"
  • Strings: "Prio.Click:Quick setup prio road/roundabout", "Prio.Click:Quick setup high prio road/roundabout","Prio.Click:Quick setup prio junction"
  • Remove "Tooltip.Keybinds:Add priority signs"
• Toggle Traffic Lights tool
  • Strings: TrafficLights.csv: "ToggleTL.Mode:Click to toggle"
• Timed Traffic Lights tool
• Speed Limits tool
• Parking Restrictions tool
  • Strings: ParkingRestrictions.csv "OnscreenHint.Mode:Click to toggle"
• Vehicle Restrictions tool
  • Strings: VehicleRestrictions.csv "OnscreenHint.Mode:Select segment", "OnscreenHint.Mode:Toggle restrictions"

Review TODO list

• TimedTL: Remove Ctrl+Click
• Prio: move Ctrl+Click above Shift+... items
• Prio: Click priority signs to toggle is confusing when editing a junction with no signs: Might be better as Click circles to change - [ ] signs ?
• Prio: Remove right click to leave //comment
• Prio: Click junction to edit will delete signs
• JR: Default text when junction selected? Click icons to toggle
• VR: Default Choose a segment to edit hint still visible even after choosing a segment: I know technically it's still valid, as I can choose another segment just by clicking it, but it just seems a little confusing from user perspective as it feels like I've done what it says (choose segment) and it's still asking me to choose segment. Maybe when segment is chosen it could change to Click icons to toggle vehicle bans ?
• VR: Delete | Bksp Revert to default
• Parking: Maybe simplify to Click icons to toggle parking ban?
• Parking: Shift + Click Apply change to whole road
• Parking: Remove [Shift]: Apply changes
• LaneConn: Right Click Leave selected node is showing while I have a lane selected: Better as Right Click Leave selected lane ?

[originalfoo]

Assuming some default text is wanted for each tool:

Junction restrictions:

Choose a junction to edit

Priority signs:

The interaction model for priority signs is grim; would be good to make it work more like Junction Restrictions if possible.

Choose a junction to edit

Toggle traffic lights:

Click junctions to toggle traffic lights

Timed traffic lights:

Maybe leave this one until we revamp the TTL UI?

Choose a junction to edit

Speed limits:

Maybe leave this one until we revamp the speed limits UI?

Parking restrictions:

Click parking icons to toggle parking

Vehicle restrictions

Choose a segment to edit

[kvakvs]

Ready for testing
Discovered bug: Speed limits window lost its background (still works)

[originalfoo]

I think speed limits should be next target for UI overhaul (separate PR obviously).

[originalfoo]

Priority signs

Can the Ctrl+Click be moved above the Shift+... items?

Click priority signs to toggle is confusing when editing a junction with no signs:

Might be better as Click circles to change signs ?

Also, right-clicking does not exit the selected node - issue with fsm?

Another issue (this is just due to bad interaction model of priority signs) - if I "click this junction to edit" I'll acutally delete the priority signs that are already there.

How much work would it be to make priority signs interaction model work more like junction restrictions?

[kvakvs]

I can modify the strings.
There is no finite state machine added to those other tools, that'd require full rewrite of the tool (namely i done that for Lane Arrows and currently doing that for Speed Limits).
The default old behaviour was that right click cannot exit. I can comment that text out.

[originalfoo]

Junction restrictions

Default text when junction selected? Click icons to toggle

[originalfoo]

Vehicle restricitons

Default Choose a segment to edit hint still visible even after choosing a segment:

I know technically it's still valid, as I can choose another segment just by clicking it, but it just seems a little confusing from user perspective as it feels like I've done what it says (choose segment) and it's still asking me to choose segment.

Maybe when segment is chosen it could change to Click icons to toggle vehicle bans ?

[originalfoo]

Parking restrictions

Maybe simplify to Click icons to toggle parking ban?

[originalfoo]

Lane connectors

Right Click Leave selected node is showing while I have a lane selected:

Better as Right Click Leave selected lane ?

[originalfoo]

Some missing shortcuts

For Parking Restrictions and Vehicle Restrictions:

• Shift + Click Apply change to whole road

For Vehicle Restrictions only:

• Delete | Backspace Revert to default

[originalfoo]

Tooltips

There's still old shortcut text in some tool buttons:

EDIT: Just realised the TTL hints is for later PR, so it's tool button tooltip can remain for now.

[originalfoo]

See comments above

[kvakvs]

Created checklist (first post) from your comments.

[kvakvs]

Found the same: missing background in Vehicle Restrictions in IMGUI window
Same as the missing background in Speed limits IMGUI
Not sure what could it be

@aubergine10 otherwise the notes above were addressed
i will need to give it a round of logging & debugging & testing to figure out missing backgrounds.

[originalfoo]

Right Click ....?

Missing locale string:

Speed limits bg is working for me:

As is vehicle restrictions:

Maybe something to do with opacity setting?

[kianzarrin]

@kvakvs can you please refresh tooltip for despawning toggle. it does not get updated when I click the button. I have to move the mouse out and back in again.

[kvakvs]

ready for another round of review
also: inverted button highlight on despawning, active is easy mode, off is hard mode.

[originalfoo]

I don't have a lane selected yet, but the Right Click hint is saying it will leave selected lane...

Other than that, looks good. Does it include the fix for tooltips updating before UI is ready (that were causing you crashes as discussed in Discord chat)?

[kvakvs]

The fix for crash was done immediately and merged with the previous ticket (for priority signs positioning), it was a severe bug.

[originalfoo]

There is still the issue with Right Click hint mentioned in #868 (comment) :

I do not have a lane selected; I only have the node selected. In this state it should be saying:

Right Click Leave selected node

[originalfoo]

LGTM based on testing in-game 👍

[krzychu124]

👍