Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "unique_label" to "name" #3

Closed
bfolie opened this issue Sep 9, 2019 · 1 comment
Closed

Change "unique_label" to "name" #3

bfolie opened this issue Sep 9, 2019 · 1 comment

Comments

@bfolie
Copy link

bfolie commented Sep 9, 2019

IngredientSpec and IngredientRun have a "unique_label" field, and ProcessTemplate has a "allowed_unique_label" field. Per the most recent docs, those should be changed to "name" and "allowed_names".

This raises questions about the HasLabels mix-in trait, which ensures that "labels" is a list of strings and "unique_label" is a string. Is it necessary to make this a separate trait? If ingredients now have a "name" field that is being used for searching the same way "name" is used for other objects, should "name" be validated as a string in the case of other objects as well?

@maxhutch
Copy link
Contributor

Closed in #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants