-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
675 different form admin #685
Conversation
Codecov Report
@@ Coverage Diff @@
## master #685 +/- ##
==========================================
- Coverage 24.16% 24.02% -0.15%
==========================================
Files 134 134
Lines 2884 2901 +17
Branches 491 495 +4
==========================================
Hits 697 697
- Misses 1813 1826 +13
- Partials 374 378 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good!
One thing, however: when the user is already logged in as an admin and wants to comment anonymously (as a regular person instead), they want to log out.
When logging out when the form is displayed, the app crashes. This is because of TypeError: Cannot read property 'displayName' of null at t.value (BaseCommentForm.js:44
So something will have to be changed so that when the user logs when the form is displayed, the form is changed, and the form must change again if the user logs out when the form is displayed :)
The above error is resolved now :) |
Implements #675