Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

675 different form admin #685

Merged
merged 6 commits into from
Jun 13, 2019
Merged

675 different form admin #685

merged 6 commits into from
Jun 13, 2019

Conversation

farrukh8925
Copy link
Contributor

@farrukh8925 farrukh8925 commented Jun 11, 2019

Implements #675

Screenshot 2019-06-11 at 17 28 05

@codecov-io
Copy link

codecov-io commented Jun 11, 2019

Codecov Report

Merging #685 into master will decrease coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
- Coverage   24.16%   24.02%   -0.15%     
==========================================
  Files         134      134              
  Lines        2884     2901      +17     
  Branches      491      495       +4     
==========================================
  Hits          697      697              
- Misses       1813     1826      +13     
- Partials      374      378       +4
Impacted Files Coverage Δ
src/components/BaseCommentForm.js 4.44% <0%> (-0.89%) ⬇️
src/App.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 132f330...f009af1. Read the comment docs.

Copy link
Contributor

@Rikuoja Rikuoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

One thing, however: when the user is already logged in as an admin and wants to comment anonymously (as a regular person instead), they want to log out.

When logging out when the form is displayed, the app crashes. This is because of TypeError: Cannot read property 'displayName' of null at t.value (BaseCommentForm.js:44

So something will have to be changed so that when the user logs when the form is displayed, the form is changed, and the form must change again if the user logs out when the form is displayed :)

@farrukh8925
Copy link
Contributor Author

The above error is resolved now :)

@Rikuoja Rikuoja merged commit ff7c45f into master Jun 13, 2019
@ranta ranta deleted the 675-Different-Form-Admin branch November 23, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants