Include plugin data in comment serialization, to obtain data for hearing visualization #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is a good idea, or at the very least it should be parametrized. Plugin data is potentially very large, and downloading all of it for every request (even those for the regular UI) is probably not actually desired. |
Rikuoja
force-pushed
the
include-plugin-data
branch
from
f3e85bb
to
c16f8bc
Compare
|
Missing tests for both new features added. |
| filtered_queryset = queryset.filter(**{queryset.model.parent_field: self.get_comment_parent_id()}) | ||
| request = self.get_serializer_context().get('request', None) | ||
| if request: | ||
| auth_code = request.GET.get('auth_code', None) |
There was a problem hiding this comment.
The request arg should probably be called authorization_code too.
How about using some sort of actual DRF filtering mechanism instead of hard-coding only one filter though?
Rikuoja
force-pushed
the
include-plugin-data
branch
from
dc5ccfe
to
0faae22
Compare
| comment_data = get_comment_data(authorization_code="foo6") | ||
| url = get_hearing_detail_url(default_hearing.id, 'comments') | ||
| api_client.post(url, comment_data) | ||
| data = get_data_from_response(api_client.get(url+'?authorization_code=foo6')) |
There was a problem hiding this comment.
Client.get() accepts the query string as a second parameter:
api_client.get(url, {"authorization_code": "foo6"})
|
Can you add a test that ensures that plugin data is not included when you don't pass in the |
Rikuoja
force-pushed
the
include-plugin-data
branch
from
62836cf
to
06ef800
Compare
|
Let's do this! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.