Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KER-257 | Hide author_name on comment endpoint for unfiltered request #452

Merged
merged 2 commits into from
Oct 18, 2023
Merged

KER-257 | Hide author_name on comment endpoint for unfiltered request #452

merged 2 commits into from
Oct 18, 2023

Commits on Oct 17, 2023

  1. Move created_by filter to the CommentFilterSet 

    Also make the filter return no results if user is not authenticated
or filter value is something else than created_by=me.

Refs KER-257
    @charn
    charn committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    124aab3 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Hide author_name on comment endpoint for unfiltered request 

    For privacy reasons the author name is not returned from the API
if a filter (hearing, section, comment, created_by) hasn't
been used.

For admin users the author name is always returned.

Refs KER-257
    @charn
    charn committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    d715b8a View commit details
    Browse the repository at this point in the history