Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preview reservation unit link disabled #1238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preview reservation unit link disabled #1238

wants to merge 1 commit into from

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Jun 12, 2024 •
edited
Loading

🛠️ Changelog

  • Fix: incorrect condition in disabling preview reservation unit on admin edit page.

🧪 Test plan

  • Manual testing: preview button (next to save) should be enabled for all created reservation units (drafts, published etc.) and should go to the public web page (with a query param that bypasses visibility checks).

🎫 Tickets

vincit-matu
vincit-matu approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@vincit-matu vincit-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincit-matu vincit-matu vincit-matu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joonatank @vincit-matu