Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create vocab_features module #143

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Create vocab_features module #143

merged 1 commit into from
Oct 24, 2018

Conversation

zweishar
Copy link
Contributor

@zweishar zweishar commented Oct 18, 2018 •
edited
Loading

Creates module that provides features vocabulary.

I've noted this in our spreadsheet, but this migration relies on the image asset migration. Once that's in place this migration should work.

davidrkupton
davidrkupton approved these changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@davidrkupton davidrkupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zweishar zweishar merged commit e80ef25 into develop Oct 24, 2018
@zweishar zweishar deleted the feature/features-vocab branch October 24, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidrkupton davidrkupton davidrkupton approved these changes

Assignees

@davidrkupton davidrkupton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zweishar @davidrkupton