Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1422/finder scaffolding + Q1 #1448

Merged
merged 18 commits into from
Sep 26, 2022
Merged

1422/finder scaffolding + Q1 #1448

merged 18 commits into from
Sep 26, 2022

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented Sep 20, 2022 •
edited
Loading

Pull Request Template

Issue Overview

This PR primarily addresses #1422 and #1433. Technically, #1423 as well which is handled by creating the feature branch.

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

This PR implements the path to the "/finder" page with a new button on the homepage, handles the design of the listing finder with the bordered field, progressNav and stepHeader which were brought over from Core, and the functionality of filtering the listings based on user's form choices for Q1. It also establishes a pattern how the form data will be stored across sections of the form and how to limit redundant code. This is subject to potentially change as more questions are implemented but it serves as an initial approach to how the user inputs could be handled.

Two thing to verify on Design @slowbot:

  1. Button sizes seemed a bit bigger in the Figma than the ones I implemented, but Detroit's is-big button looks like a box (overrides might be missing the is-big case). Let me know if you want me to pursue the bigger buttons or if the current implementation looks good to you.

How Can This Be Tested/Reviewed?

This can be tested by going to the detroit homepage, selecting the new 'Find listings for you' button, and doing one of two things: 1) clicking skip and seeing the All rentals view 2) filling out the form and clicking submit to see your selections reflected in the filtered listings page.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • I have exported any new pieces added to ui-components
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@ColinBuyck ColinBuyck added the wip label Sep 20, 2022
ludtkemorgan
ludtkemorgan requested changes Sep 21, 2022
View reviewed changes
sites/public/pages/finder.tsx Outdated
<div className="finder-grid">
{activeQuestion["fields"]?.map((field) => {
return (
<div className="finder-grid__field">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a key on this div

sites/public/layouts/eligibility.tsx Outdated
@@ -66,7 +66,7 @@ const EligibilityLayout = (props: EligibilityLayoutProps) => {
t(`eligibility.progress.sections.${label}`)
)}
mounted={OnClientSide()}
routes={ELIGIBILITY_SECTIONS.map((_label, i) => eligibilityRoute(i))}
// routes={ELIGIBILITY_SECTIONS.map((_label, i) => eligibilityRoute(i))}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be deleted? or is there a reason it is commented out?

sites/public/styles/headers.scss
Comment on lines +307 to +311
&:hover {
color: var(--bloom-color-white);
box-shadow: 0 0 0 var(--bloom-s0_5) var(--bloom-color-primary-dark) inset;
background-color: var(--bloom-color-black);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The normal Detroit button on hover doesn't go to a darker color, but rather switches to an outlined version. Is this the standard that we want to keep? https://storybook.bloom.exygy.dev/?path=/story/actions-button--detroit-style

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ludtkemorgan Talked about this one offline a bit with Jesse and he pointed me to these docs: https://www.figma.com/file/slSZvBKEUduz5ldBiDsIzE/detroit-style-guide?node-id=0%3A33. Seems like storybook dev will need to be updated though to reflect this.

sites/public/pages/finder.tsx Outdated
const getAndSetOptions = async () => {
try {
const response = await axios.get(`${process.env.backendApiBase}/listings/meta`)
// console.log(response.data)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

sites/public/pages/finder.tsx Outdated
Comment on lines 53 to 54
const [currentStep, setCurrentStep] = useState<number>(1)
const [completedSteps, setCompletedSteps] = useState<number>(0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is completedSteps always going to be just one less than currentStep? If so, I think you could get away with just having one useState for currentStep and then everywhere completedSteps is used just do currentStep - 1

sites/public/pages/finder.tsx Outdated
<ProgressNav
currentPageSection={currentStep}
completedSections={completedSteps}
labels={["Housing Needs", "Accessibility", "Building Types"]}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be put into the localization file

sites/public/pages/finder.tsx
<div className="flex flex-col w-full">
<div className="flex flex-row justify-between">
<div className="md:text-xl capitalize font-bold">
{t("listingFilters.buttonTitleExtended")}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In mobile view the header and stepHeader doesn't have any padding between it and the site header
image

emilyjablonski
emilyjablonski requested changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments! The only blocker for me is the mobile layout adjustments

sites/public/page_content/locale_overrides/general.json Outdated
@@ -34,5 +34,9 @@
"basicsVideo.incomeRestrictionsSubtitle": "In this video, learn about income requirements for affordable housing that is paid for by governmental resources.",
"basicsVideo.residentTutorial": "Detroit Home Connect Resident Tutorial",
"basicsVideo.residentTutorialSubtitle": "Learn how to use the City's affordable housing locator, Detroit Home Connect, to understand affordable housing options in the City.",
"basicsCard.sectionTitle": "Learn more about the basics of affordable housing"
"basicsCard.sectionTitle": "Learn more about the basics of affordable housing",
"finder.bedRoomSize.question": "What types of rentals are you interested in?",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many bedrooms do you need? looks like the string in the Figma

sites/public/pages/finder.tsx Outdated
import Layout from "../layouts/application"

const getTranslationString = (str: string) => {
if (str === "studio") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a style preference but I'd likely just use a "map" here
const map = { "studio": "studioPlus", ... } and then map[str]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a lot cleaner! Implemented!

sites/public/pages/finder.tsx Outdated
try {
const response = await axios.get(`${process.env.backendApiBase}/listings/meta`)
// console.log(response.data)
if (response.data) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be one if with response?.data?.unitTypes

sites/public/pages/finder.tsx Outdated
<StepHeader
currentStep={currentStep}
totalSteps={3}
stepPreposition={"of"}
Copy link
Collaborator

@emilyjablonski emilyjablonski Sep 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs translations

sites/public/pages/finder.tsx Outdated
formData[currentStep]["fields"].forEach(
(field) => (field["selected"] = userSelections.includes(field))
)
setCompletedSteps(completedSteps + 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep track of both completed and current? Can we assume the number of completed based on the current step and the total steps?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now we don't need the two! Only thing I was considering in keeping both is handling the disclaimer page after all of the steps, but it will definitely be easier to cover that case as part of the later PR.

sites/public/pages/finder.tsx Outdated
</div>

<div className="bg-gray-300 flex flex-row-reverse justify-between py-8 px-20">
{/* change as more questions added */}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the total number of questions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to adjust the handling of state a bit for this one (formData as state rather than just active question), but I agree that it is better with a length check!

sites/public/styles/forms.scss Outdated
@@ -1,7 +1,7 @@
.progress-nav {
padding: 20px 0;
@screen md {
padding: 31px 0;
padding: 32px 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2rem

sites/public/styles/forms.scss
column-gap: 0.5rem;
.finder-grid__field {
.field {
--leftward-margin: 0rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦑

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol

@ColinBuyck ColinBuyck changed the title 1422/finder scaffolding 1422/finder scaffolding + Q1 Sep 21, 2022
@emilyjablonski
Copy link
Collaborator

Screen Shot 2022-09-23 at 1 42 13 PM

I think the mobile might still need some more adjustment with increased padding on the progress bar and decreased padding on the form

@ColinBuyck
Copy link
Collaborator Author

@emilyjablonski Just updated, thanks!

ludtkemorgan
ludtkemorgan approved these changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. I only spotted a few small things. Assuming you make the changes and Emily is ok with the mobile/tablet view I'm going to approve it now

ui-components/src/navigation/ProgressNav.tsx
} else if (props.section > props.currentPageSection) {
return (
<span className="sr-only">
{props.strings?.screenReaderNotCompleted ?? t("progressNav.notCompleted")}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

progressNav.notCompleted and progressNav.completed need to be added to the general.json file for ui-components

sites/public/pages/finder.tsx Outdated
) : (
<Button
type="button"
onClick={() => nextQuestion()}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to create a new arrow function here. You could just do onClick={nextQuestion}. Same for the previous question

@ColinBuyck
Copy link
Collaborator Author

@ludtkemorgan Just made those improvements. Thank you for the review!

emilyjablonski
emilyjablonski approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@ColinBuyck ColinBuyck merged commit c8f1aec into feat/listings-finder Sep 26, 2022
@ColinBuyck ColinBuyck deleted the 1422/finder-scaffolding branch September 26, 2022 19:04
ColinBuyck added a commit that referenced this pull request Nov 1, 2022
@ColinBuyck
Listings Finder Feature Builder (#1453)
90375a7 
* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1434/listing finder q2 (#1452)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: pr cleanup

* fix: typos + field value refactor

* fix: auto-submit issue

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* 1444+5/listing finder q4+5 (#1472)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: remove empty div

* fix: remove logs

* fix: no results bug

* fix: minor border issue

* fix: disclaimer unique key

* 1460/listing finder translations (#1473)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: getting started

* fix: wip translations w/o changes

* fix: wip updating content

* fix: completed translations w/o questions

* fix: rent placeholder handling

* fix: removed json comment

* fix: remove families program

* fix: neighborhood translations

* fix: hompage button fix

* fix: added feature flagging

* fix: missing env config

* fix: update env naming

* fix: template updates
ColinBuyck added a commit that referenced this pull request Nov 1, 2022
@ColinBuyck
1422/finder scaffolding + Q1 (#1448)
6192565 
* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup
ColinBuyck added a commit that referenced this pull request Nov 10, 2022
@ColinBuyck
1486/listing finder refactor (#1487)
c9eee79 
* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1434/listing finder q2 (#1452)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: pr cleanup

* fix: typos + field value refactor

* fix: auto-submit issue

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* 1444+5/listing finder q4+5 (#1472)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: remove empty div

* fix: remove logs

* fix: no results bug

* fix: minor border issue

* fix: disclaimer unique key

* 1460/listing finder translations (#1473)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: getting started

* fix: wip translations w/o changes

* fix: wip updating content

* fix: completed translations w/o questions

* fix: rent placeholder handling

* fix: removed json comment

* fix: remove families program

* fix: neighborhood translations

* fix: hompage button fix

* fix: added feature flagging

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* fix: qa visual updates

* fix: mobile header spacing refinement

* fix: expand card componenet vars

* fix: refined breakpoints

* fix: removed unused css

* fix: updated mobile header size

* fix: simplified finder card css
ludtkemorgan pushed a commit that referenced this pull request Nov 16, 2022
@ColinBuyck @ludtkemorgan
Listings Finder Feature Builder (#1453)
1e9d990 
* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1434/listing finder q2 (#1452)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: pr cleanup

* fix: typos + field value refactor

* fix: auto-submit issue

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* 1444+5/listing finder q4+5 (#1472)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: remove empty div

* fix: remove logs

* fix: no results bug

* fix: minor border issue

* fix: disclaimer unique key

* 1460/listing finder translations (#1473)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: getting started

* fix: wip translations w/o changes

* fix: wip updating content

* fix: completed translations w/o questions

* fix: rent placeholder handling

* fix: removed json comment

* fix: remove families program

* fix: neighborhood translations

* fix: hompage button fix

* fix: added feature flagging

* fix: missing env config

* fix: update env naming

* fix: template updates
ludtkemorgan pushed a commit that referenced this pull request Nov 16, 2022
@ColinBuyck @ludtkemorgan
1486/listing finder refactor (#1487)
cba84a9 
* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1434/listing finder q2 (#1452)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: pr cleanup

* fix: typos + field value refactor

* fix: auto-submit issue

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* 1444+5/listing finder q4+5 (#1472)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: remove empty div

* fix: remove logs

* fix: no results bug

* fix: minor border issue

* fix: disclaimer unique key

* 1460/listing finder translations (#1473)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: getting started

* fix: wip translations w/o changes

* fix: wip updating content

* fix: completed translations w/o questions

* fix: rent placeholder handling

* fix: removed json comment

* fix: remove families program

* fix: neighborhood translations

* fix: hompage button fix

* fix: added feature flagging

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* fix: qa visual updates

* fix: mobile header spacing refinement

* fix: expand card componenet vars

* fix: refined breakpoints

* fix: removed unused css

* fix: updated mobile header size

* fix: simplified finder card css
ColinBuyck added a commit that referenced this pull request Nov 17, 2022
@ColinBuyck
1491/finder a11y fixes (#1493)
85efc4d 
* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1434/listing finder q2 (#1452)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: pr cleanup

* fix: typos + field value refactor

* fix: auto-submit issue

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* 1444+5/listing finder q4+5 (#1472)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: remove empty div

* fix: remove logs

* fix: no results bug

* fix: minor border issue

* fix: disclaimer unique key

* 1460/listing finder translations (#1473)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: getting started

* fix: wip translations w/o changes

* fix: wip updating content

* fix: completed translations w/o questions

* fix: rent placeholder handling

* fix: removed json comment

* fix: remove families program

* fix: neighborhood translations

* fix: hompage button fix

* fix: added feature flagging

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* fix: qa visual updates

* fix: mobile header spacing refinement

* fix: expand card componenet vars

* fix: refined breakpoints

* fix: removed unused css

* fix: updated mobile header size

* fix: simplified finder card css

* fix: various focus/priority improvements

* fix: added legend texts

* fix: wip reset focus

* fix: current focus solution
ludtkemorgan pushed a commit that referenced this pull request Nov 17, 2022
@ColinBuyck @ludtkemorgan
1491/finder a11y fixes (#1493)
ed20c57 
* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1434/listing finder q2 (#1452)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: pr cleanup

* fix: typos + field value refactor

* fix: auto-submit issue

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* 1444+5/listing finder q4+5 (#1472)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: remove empty div

* fix: remove logs

* fix: no results bug

* fix: minor border issue

* fix: disclaimer unique key

* 1460/listing finder translations (#1473)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: getting started

* fix: wip translations w/o changes

* fix: wip updating content

* fix: completed translations w/o questions

* fix: rent placeholder handling

* fix: removed json comment

* fix: remove families program

* fix: neighborhood translations

* fix: hompage button fix

* fix: added feature flagging

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* fix: qa visual updates

* fix: mobile header spacing refinement

* fix: expand card componenet vars

* fix: refined breakpoints

* fix: removed unused css

* fix: updated mobile header size

* fix: simplified finder card css

* fix: various focus/priority improvements

* fix: added legend texts

* fix: wip reset focus

* fix: current focus solution
ludtkemorgan added a commit that referenced this pull request Nov 17, 2022
@ludtkemorgan @dependabot
@emilyjablonski @ColinBuyck @KrissDrawing @YazeedLoonat
feat: release 2022-11-16 (#1506)
cf8e59d 
* build(deps): bump github/codeql-action from 1 to 2 (#1375)

* fix: allow deletion of users

* chore: standardize the typescript version (bloom-housing#3086)

* feat: add neighborhood amenities to listing

* fix: update activity-log relationship to users for deletion

* fix: table columns should take up full width (bloom-housing#3005)

* 1449/filter no results (#1476)

* fix: wip action block

* fix: custom block css

* fix: matching spacing to figma

* fix: removed custom styling

* feat: add neighborhood amenities to partners (#1467)

* feat: add neighborhood amenities input section

* feat: add neighborhood amenities details section

* feat: add details neighborhood amenities section

* test: neighborhood amenities partners fields

* feat: update neighborhood amenities subtitle

* feat: move titles to partners folder

* fix: switch listing to server side props (bloom-housing#3145) (#1484)

* feat: add neighborhood amenities to public site (#1470)

* feat: add neighborhood amenities to public listing description

* feat: move amenities section into neighborhood on mobile

* feat: add get directions link under the map

* Listings Finder Feature Builder (#1453)

* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1434/listing finder q2 (#1452)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: pr cleanup

* fix: typos + field value refactor

* fix: auto-submit issue

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* 1444+5/listing finder q4+5 (#1472)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: remove empty div

* fix: remove logs

* fix: no results bug

* fix: minor border issue

* fix: disclaimer unique key

* 1460/listing finder translations (#1473)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: getting started

* fix: wip translations w/o changes

* fix: wip updating content

* fix: completed translations w/o questions

* fix: rent placeholder handling

* fix: removed json comment

* fix: remove families program

* fix: neighborhood translations

* fix: hompage button fix

* fix: added feature flagging

* fix: missing env config

* fix: update env naming

* fix: template updates

* feat: update leasing agent and developer translations (#1496)

* 1486/listing finder refactor (#1487)

* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1434/listing finder q2 (#1452)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: pr cleanup

* fix: typos + field value refactor

* fix: auto-submit issue

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* 1444+5/listing finder q4+5 (#1472)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: remove empty div

* fix: remove logs

* fix: no results bug

* fix: minor border issue

* fix: disclaimer unique key

* 1460/listing finder translations (#1473)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: getting started

* fix: wip translations w/o changes

* fix: wip updating content

* fix: completed translations w/o questions

* fix: rent placeholder handling

* fix: removed json comment

* fix: remove families program

* fix: neighborhood translations

* fix: hompage button fix

* fix: added feature flagging

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* fix: qa visual updates

* fix: mobile header spacing refinement

* fix: expand card componenet vars

* fix: refined breakpoints

* fix: removed unused css

* fix: updated mobile header size

* fix: simplified finder card css

* fix: added missing translations (#1500)

* fix: set neighborhood amenities to null when all sub fields empty (#1495)

* fix: set neighborhood amenities to null when all sub fields empty

* refactor: move neighborhood amenities on submit modification to formatter

* fix: update for swagger changes (#1503)

Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com>

* feat: update neighborhood amenities fields (#1494)

* fix: upgrade ioredis version (#1505)

* fix: checkbox in bordered field in arabic (#1504)

* fix: checkbox in bordered field in arabic

* fix: update class names

* fix: revert to existing padding

Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>

* 1491/finder a11y fixes (#1493)

* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1434/listing finder q2 (#1452)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: pr cleanup

* fix: typos + field value refactor

* fix: auto-submit issue

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* 1444+5/listing finder q4+5 (#1472)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: remove empty div

* fix: remove logs

* fix: no results bug

* fix: minor border issue

* fix: disclaimer unique key

* 1460/listing finder translations (#1473)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: getting started

* fix: wip translations w/o changes

* fix: wip updating content

* fix: completed translations w/o questions

* fix: rent placeholder handling

* fix: removed json comment

* fix: remove families program

* fix: neighborhood translations

* fix: hompage button fix

* fix: added feature flagging

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* fix: qa visual updates

* fix: mobile header spacing refinement

* fix: expand card componenet vars

* fix: refined breakpoints

* fix: removed unused css

* fix: updated mobile header size

* fix: simplified finder card css

* fix: various focus/priority improvements

* fix: added legend texts

* fix: wip reset focus

* fix: current focus solution

* fix: prettier code style fixes

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com>
Co-authored-by: Krzysztof Zięcina <kriss.kontakt@gmail.com>
Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com>
Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludtkemorgan ludtkemorgan ludtkemorgan approved these changes

@emilyjablonski emilyjablonski emilyjablonski approved these changes

Assignees

@ludtkemorgan ludtkemorgan

@emilyjablonski emilyjablonski

Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ColinBuyck @emilyjablonski @ludtkemorgan