Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: checkbox in bordered field in arabic #1504

Merged
merged 3 commits into from
Nov 17, 2022
Merged

fix: checkbox in bordered field in arabic #1504

merged 3 commits into from
Nov 17, 2022

Conversation

KrissDrawing
Copy link
Collaborator

Pull Request Template

Issue Overview

This PR addresses #1474

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

If i get correctly we use text-indent to display over margin in Field. It doesn't transfer good for rtl for some reason. So handled it just with padding, shouldn't affect other variants of Field.

How Can This Be Tested/Reviewed?

Go to /finder switch language to arabic, check if it displays properly.
If you can think of other Field's that can be affected by that change, also check those

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • I have exported any new pieces added to ui-components
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify
Copy link

netlify bot commented Nov 16, 2022 •
edited
Loading

✅ Deploy Preview for detroit-public-dev ready!

Name Link
🔨 Latest commit 4606832
🔍 Latest deploy log https://app.netlify.com/sites/detroit-public-dev/deploys/637585b5535f680008a2c729
😎 Deploy Preview https://deploy-preview-1504--detroit-public-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 16, 2022 •
edited
Loading

✅ Deploy Preview for detroit-storybook-dev ready!

Name Link
🔨 Latest commit 4606832
🔍 Latest deploy log https://app.netlify.com/sites/detroit-storybook-dev/deploys/637585b5844d920009231a75
😎 Deploy Preview https://deploy-preview-1504--detroit-storybook-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 16, 2022 •
edited
Loading

✅ Deploy Preview for detroit-partners-dev ready!

Name Link
🔨 Latest commit 4606832
🔍 Latest deploy log https://app.netlify.com/sites/detroit-partners-dev/deploys/637585b5f067560008e43ba6
😎 Deploy Preview https://deploy-preview-1504--detroit-partners-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

emilyjablonski
emilyjablonski reviewed Nov 16, 2022
View reviewed changes
ui-components/src/global/forms.scss Outdated
border-width: var(--bordered-border-width);
border-radius: var(--bordered-border-radius);
border-color: var(--bloom-color-gray-450);
text-indent: 0 !important;
Copy link
Collaborator

@emilyjablonski emilyjablonski Nov 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we can accomplish this fix and avoid having to add this style with !important by just changing --bordered-leftward-padding and --bordered-rightward-padding to 3rem, what do you think?

ColinBuyck
ColinBuyck approved these changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥬

@ColinBuyck ColinBuyck merged commit db96740 into dev Nov 17, 2022
@ColinBuyck ColinBuyck deleted the 1474/Incorrect-Bordered-Field-UI-with-Arabic branch November 17, 2022 01:06
ludtkemorgan pushed a commit that referenced this pull request Nov 17, 2022
@KrissDrawing @emilyjablonski @ludtkemorgan
fix: checkbox in bordered field in arabic (#1504)
4b0178a 
* fix: checkbox in bordered field in arabic

* fix: update class names

* fix: revert to existing padding

Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>
ludtkemorgan added a commit that referenced this pull request Nov 17, 2022
@ludtkemorgan @dependabot
@emilyjablonski @ColinBuyck @KrissDrawing @YazeedLoonat
feat: release 2022-11-16 (#1506)
cf8e59d 
* build(deps): bump github/codeql-action from 1 to 2 (#1375)

* fix: allow deletion of users

* chore: standardize the typescript version (bloom-housing#3086)

* feat: add neighborhood amenities to listing

* fix: update activity-log relationship to users for deletion

* fix: table columns should take up full width (bloom-housing#3005)

* 1449/filter no results (#1476)

* fix: wip action block

* fix: custom block css

* fix: matching spacing to figma

* fix: removed custom styling

* feat: add neighborhood amenities to partners (#1467)

* feat: add neighborhood amenities input section

* feat: add neighborhood amenities details section

* feat: add details neighborhood amenities section

* test: neighborhood amenities partners fields

* feat: update neighborhood amenities subtitle

* feat: move titles to partners folder

* fix: switch listing to server side props (bloom-housing#3145) (#1484)

* feat: add neighborhood amenities to public site (#1470)

* feat: add neighborhood amenities to public listing description

* feat: move amenities section into neighborhood on mobile

* feat: add get directions link under the map

* Listings Finder Feature Builder (#1453)

* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1434/listing finder q2 (#1452)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: pr cleanup

* fix: typos + field value refactor

* fix: auto-submit issue

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* 1444+5/listing finder q4+5 (#1472)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: remove empty div

* fix: remove logs

* fix: no results bug

* fix: minor border issue

* fix: disclaimer unique key

* 1460/listing finder translations (#1473)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: getting started

* fix: wip translations w/o changes

* fix: wip updating content

* fix: completed translations w/o questions

* fix: rent placeholder handling

* fix: removed json comment

* fix: remove families program

* fix: neighborhood translations

* fix: hompage button fix

* fix: added feature flagging

* fix: missing env config

* fix: update env naming

* fix: template updates

* feat: update leasing agent and developer translations (#1496)

* 1486/listing finder refactor (#1487)

* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1434/listing finder q2 (#1452)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: pr cleanup

* fix: typos + field value refactor

* fix: auto-submit issue

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* 1444+5/listing finder q4+5 (#1472)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: remove empty div

* fix: remove logs

* fix: no results bug

* fix: minor border issue

* fix: disclaimer unique key

* 1460/listing finder translations (#1473)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: getting started

* fix: wip translations w/o changes

* fix: wip updating content

* fix: completed translations w/o questions

* fix: rent placeholder handling

* fix: removed json comment

* fix: remove families program

* fix: neighborhood translations

* fix: hompage button fix

* fix: added feature flagging

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* fix: qa visual updates

* fix: mobile header spacing refinement

* fix: expand card componenet vars

* fix: refined breakpoints

* fix: removed unused css

* fix: updated mobile header size

* fix: simplified finder card css

* fix: added missing translations (#1500)

* fix: set neighborhood amenities to null when all sub fields empty (#1495)

* fix: set neighborhood amenities to null when all sub fields empty

* refactor: move neighborhood amenities on submit modification to formatter

* fix: update for swagger changes (#1503)

Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com>

* feat: update neighborhood amenities fields (#1494)

* fix: upgrade ioredis version (#1505)

* fix: checkbox in bordered field in arabic (#1504)

* fix: checkbox in bordered field in arabic

* fix: update class names

* fix: revert to existing padding

Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>

* 1491/finder a11y fixes (#1493)

* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1434/listing finder q2 (#1452)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: pr cleanup

* fix: typos + field value refactor

* fix: auto-submit issue

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* 1444+5/listing finder q4+5 (#1472)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: remove empty div

* fix: remove logs

* fix: no results bug

* fix: minor border issue

* fix: disclaimer unique key

* 1460/listing finder translations (#1473)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: wip added question content

* fix: program filtering id

* fix: getting started

* fix: wip translations w/o changes

* fix: wip updating content

* fix: completed translations w/o questions

* fix: rent placeholder handling

* fix: removed json comment

* fix: remove families program

* fix: neighborhood translations

* fix: hompage button fix

* fix: added feature flagging

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* 1422/finder scaffolding + Q1 (#1448)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: mobile styling

* fix: string + OnClick cleanup

* 1443/listing finder disclaimer (#1461)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: remove unused  div

* fix: skip functionality + PR feedback

* fix: refine react code

* 1442/listing finder q3 (#1463)

* fix: added components from core

* fix: basic components

* fix: added copy components

* fix: core component updates

* fix: homepage finder button

* fix: wip css refinements

* fix: basic form functioning

* fix: corrected homepage button design

* fix: build error resolved

* fix: added strings to json

* fix: object pattern for multiple questions

* fix: clean-up mobile view

* fix: corrected padding

* fix: cleanup from feedback

* fix: px to rem

* fix: basic question info

* fix: mobile styling

* fix: improved form state handling

* fix: filtering with all inputs

* fix: refined step logic

* fix: disclaimer content

* fix: list styling

* fix: updated design

* fix: css refinements

* fix: clean up

* fix: logic clean up

* fix: handling disclaimer page w/ state

* fix: remove unused code

* fix: wip handling rent range

* fix: separate question types

* fix: rental costs basic functionality

* fix: refine css styling

* fix: content updates

* fix: error handling + cleanup

* fix: use of type field

* fix: improved translations

* fix: improved error handling

* fix: removed unused div

* fix: component sync

* fix: wip refactor

* fix: wip 2 refactor

* fix: wip 3 refactor

* fix: qa visual updates

* fix: mobile header spacing refinement

* fix: expand card componenet vars

* fix: refined breakpoints

* fix: removed unused css

* fix: updated mobile header size

* fix: simplified finder card css

* fix: various focus/priority improvements

* fix: added legend texts

* fix: wip reset focus

* fix: current focus solution

* fix: prettier code style fixes

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com>
Co-authored-by: Krzysztof Zięcina <kriss.kontakt@gmail.com>
Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com>
Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyjablonski emilyjablonski emilyjablonski left review comments

@ludtkemorgan ludtkemorgan ludtkemorgan approved these changes

@ColinBuyck ColinBuyck ColinBuyck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KrissDrawing @ludtkemorgan @ColinBuyck @emilyjablonski