-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1442/listing finder q3 #1463
1442/listing finder q3 #1463
Conversation
errorMessage={ | ||
isMin ? t("errors.minGreaterThanMaxRentError") : t("errors.maxLessThanMinRentError") | ||
} | ||
validation={isMin ? { max: props.maxRent || props.minRent } : { min: props.minRent }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm able to type negative numbers into the minimum rent box. Could be fixed by adding min: 0
to the validation here
{numericFields.map((field) => { | ||
const isMin = field.label === "minRent" | ||
return ( | ||
<div className="finder-grid__field"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There needs to be a unique key here
import { UseFormMethods } from "react-hook-form" | ||
import { FinderQuestion } from "../../../pages/finder" | ||
|
||
const FinderRentalCosts = (props: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to go down the route where you don't have to pass in all of these props, you could switch to the useFormContext
style. https://react-hook-form.com/api/useformcontext/. With a fairly small form this isn't necessary though. But if more questions (non multi-select ones) we might want to think to moving to that style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! I'll keep this in mind going forward
@ludtkemorgan Those issues should be addressed now 🌞 |
sites/public/pages/finder.tsx
Outdated
{!isDisclaimer | ||
? t("finder.question.subtitle") | ||
: t("finder.disclaimer.subtitle")} | ||
<div className=""> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes!
* 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1434/listing finder q2 (#1452) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: pr cleanup * fix: typos + field value refactor * fix: auto-submit issue * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * 1444+5/listing finder q4+5 (#1472) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: remove empty div * fix: remove logs * fix: no results bug * fix: minor border issue * fix: disclaimer unique key * 1460/listing finder translations (#1473) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: getting started * fix: wip translations w/o changes * fix: wip updating content * fix: completed translations w/o questions * fix: rent placeholder handling * fix: removed json comment * fix: remove families program * fix: neighborhood translations * fix: hompage button fix * fix: added feature flagging * fix: missing env config * fix: update env naming * fix: template updates
* fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div
* 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1434/listing finder q2 (#1452) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: pr cleanup * fix: typos + field value refactor * fix: auto-submit issue * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * 1444+5/listing finder q4+5 (#1472) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: remove empty div * fix: remove logs * fix: no results bug * fix: minor border issue * fix: disclaimer unique key * 1460/listing finder translations (#1473) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: getting started * fix: wip translations w/o changes * fix: wip updating content * fix: completed translations w/o questions * fix: rent placeholder handling * fix: removed json comment * fix: remove families program * fix: neighborhood translations * fix: hompage button fix * fix: added feature flagging * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * fix: qa visual updates * fix: mobile header spacing refinement * fix: expand card componenet vars * fix: refined breakpoints * fix: removed unused css * fix: updated mobile header size * fix: simplified finder card css
* 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1434/listing finder q2 (#1452) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: pr cleanup * fix: typos + field value refactor * fix: auto-submit issue * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * 1444+5/listing finder q4+5 (#1472) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: remove empty div * fix: remove logs * fix: no results bug * fix: minor border issue * fix: disclaimer unique key * 1460/listing finder translations (#1473) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: getting started * fix: wip translations w/o changes * fix: wip updating content * fix: completed translations w/o questions * fix: rent placeholder handling * fix: removed json comment * fix: remove families program * fix: neighborhood translations * fix: hompage button fix * fix: added feature flagging * fix: missing env config * fix: update env naming * fix: template updates
* 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1434/listing finder q2 (#1452) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: pr cleanup * fix: typos + field value refactor * fix: auto-submit issue * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * 1444+5/listing finder q4+5 (#1472) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: remove empty div * fix: remove logs * fix: no results bug * fix: minor border issue * fix: disclaimer unique key * 1460/listing finder translations (#1473) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: getting started * fix: wip translations w/o changes * fix: wip updating content * fix: completed translations w/o questions * fix: rent placeholder handling * fix: removed json comment * fix: remove families program * fix: neighborhood translations * fix: hompage button fix * fix: added feature flagging * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * fix: qa visual updates * fix: mobile header spacing refinement * fix: expand card componenet vars * fix: refined breakpoints * fix: removed unused css * fix: updated mobile header size * fix: simplified finder card css
* 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1434/listing finder q2 (#1452) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: pr cleanup * fix: typos + field value refactor * fix: auto-submit issue * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * 1444+5/listing finder q4+5 (#1472) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: remove empty div * fix: remove logs * fix: no results bug * fix: minor border issue * fix: disclaimer unique key * 1460/listing finder translations (#1473) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: getting started * fix: wip translations w/o changes * fix: wip updating content * fix: completed translations w/o questions * fix: rent placeholder handling * fix: removed json comment * fix: remove families program * fix: neighborhood translations * fix: hompage button fix * fix: added feature flagging * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * fix: qa visual updates * fix: mobile header spacing refinement * fix: expand card componenet vars * fix: refined breakpoints * fix: removed unused css * fix: updated mobile header size * fix: simplified finder card css * fix: various focus/priority improvements * fix: added legend texts * fix: wip reset focus * fix: current focus solution
* 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1434/listing finder q2 (#1452) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: pr cleanup * fix: typos + field value refactor * fix: auto-submit issue * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * 1444+5/listing finder q4+5 (#1472) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: remove empty div * fix: remove logs * fix: no results bug * fix: minor border issue * fix: disclaimer unique key * 1460/listing finder translations (#1473) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: getting started * fix: wip translations w/o changes * fix: wip updating content * fix: completed translations w/o questions * fix: rent placeholder handling * fix: removed json comment * fix: remove families program * fix: neighborhood translations * fix: hompage button fix * fix: added feature flagging * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * fix: qa visual updates * fix: mobile header spacing refinement * fix: expand card componenet vars * fix: refined breakpoints * fix: removed unused css * fix: updated mobile header size * fix: simplified finder card css * fix: various focus/priority improvements * fix: added legend texts * fix: wip reset focus * fix: current focus solution
* build(deps): bump github/codeql-action from 1 to 2 (#1375) * fix: allow deletion of users * chore: standardize the typescript version (bloom-housing#3086) * feat: add neighborhood amenities to listing * fix: update activity-log relationship to users for deletion * fix: table columns should take up full width (bloom-housing#3005) * 1449/filter no results (#1476) * fix: wip action block * fix: custom block css * fix: matching spacing to figma * fix: removed custom styling * feat: add neighborhood amenities to partners (#1467) * feat: add neighborhood amenities input section * feat: add neighborhood amenities details section * feat: add details neighborhood amenities section * test: neighborhood amenities partners fields * feat: update neighborhood amenities subtitle * feat: move titles to partners folder * fix: switch listing to server side props (bloom-housing#3145) (#1484) * feat: add neighborhood amenities to public site (#1470) * feat: add neighborhood amenities to public listing description * feat: move amenities section into neighborhood on mobile * feat: add get directions link under the map * Listings Finder Feature Builder (#1453) * 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1434/listing finder q2 (#1452) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: pr cleanup * fix: typos + field value refactor * fix: auto-submit issue * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * 1444+5/listing finder q4+5 (#1472) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: remove empty div * fix: remove logs * fix: no results bug * fix: minor border issue * fix: disclaimer unique key * 1460/listing finder translations (#1473) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: getting started * fix: wip translations w/o changes * fix: wip updating content * fix: completed translations w/o questions * fix: rent placeholder handling * fix: removed json comment * fix: remove families program * fix: neighborhood translations * fix: hompage button fix * fix: added feature flagging * fix: missing env config * fix: update env naming * fix: template updates * feat: update leasing agent and developer translations (#1496) * 1486/listing finder refactor (#1487) * 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1434/listing finder q2 (#1452) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: pr cleanup * fix: typos + field value refactor * fix: auto-submit issue * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * 1444+5/listing finder q4+5 (#1472) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: remove empty div * fix: remove logs * fix: no results bug * fix: minor border issue * fix: disclaimer unique key * 1460/listing finder translations (#1473) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: getting started * fix: wip translations w/o changes * fix: wip updating content * fix: completed translations w/o questions * fix: rent placeholder handling * fix: removed json comment * fix: remove families program * fix: neighborhood translations * fix: hompage button fix * fix: added feature flagging * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * fix: qa visual updates * fix: mobile header spacing refinement * fix: expand card componenet vars * fix: refined breakpoints * fix: removed unused css * fix: updated mobile header size * fix: simplified finder card css * fix: added missing translations (#1500) * fix: set neighborhood amenities to null when all sub fields empty (#1495) * fix: set neighborhood amenities to null when all sub fields empty * refactor: move neighborhood amenities on submit modification to formatter * fix: update for swagger changes (#1503) Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com> * feat: update neighborhood amenities fields (#1494) * fix: upgrade ioredis version (#1505) * fix: checkbox in bordered field in arabic (#1504) * fix: checkbox in bordered field in arabic * fix: update class names * fix: revert to existing padding Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com> * 1491/finder a11y fixes (#1493) * 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1434/listing finder q2 (#1452) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: pr cleanup * fix: typos + field value refactor * fix: auto-submit issue * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * 1444+5/listing finder q4+5 (#1472) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: remove empty div * fix: remove logs * fix: no results bug * fix: minor border issue * fix: disclaimer unique key * 1460/listing finder translations (#1473) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: wip added question content * fix: program filtering id * fix: getting started * fix: wip translations w/o changes * fix: wip updating content * fix: completed translations w/o questions * fix: rent placeholder handling * fix: removed json comment * fix: remove families program * fix: neighborhood translations * fix: hompage button fix * fix: added feature flagging * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * 1422/finder scaffolding + Q1 (#1448) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: mobile styling * fix: string + OnClick cleanup * 1443/listing finder disclaimer (#1461) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: remove unused div * fix: skip functionality + PR feedback * fix: refine react code * 1442/listing finder q3 (#1463) * fix: added components from core * fix: basic components * fix: added copy components * fix: core component updates * fix: homepage finder button * fix: wip css refinements * fix: basic form functioning * fix: corrected homepage button design * fix: build error resolved * fix: added strings to json * fix: object pattern for multiple questions * fix: clean-up mobile view * fix: corrected padding * fix: cleanup from feedback * fix: px to rem * fix: basic question info * fix: mobile styling * fix: improved form state handling * fix: filtering with all inputs * fix: refined step logic * fix: disclaimer content * fix: list styling * fix: updated design * fix: css refinements * fix: clean up * fix: logic clean up * fix: handling disclaimer page w/ state * fix: remove unused code * fix: wip handling rent range * fix: separate question types * fix: rental costs basic functionality * fix: refine css styling * fix: content updates * fix: error handling + cleanup * fix: use of type field * fix: improved translations * fix: improved error handling * fix: removed unused div * fix: component sync * fix: wip refactor * fix: wip 2 refactor * fix: wip 3 refactor * fix: qa visual updates * fix: mobile header spacing refinement * fix: expand card componenet vars * fix: refined breakpoints * fix: removed unused css * fix: updated mobile header size * fix: simplified finder card css * fix: various focus/priority improvements * fix: added legend texts * fix: wip reset focus * fix: current focus solution * fix: prettier code style fixes Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com> Co-authored-by: Krzysztof Zięcina <kriss.kontakt@gmail.com> Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com> Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>
Pull Request Template
Issue Overview
This PR addresses #1442
Description
This PR builds out q3 of the listings finder. Since q3 introduced a new pattern, it warranted a refactor of the finder to utilize separate custom components rather than trying to contain all the cases within finder.tsx.
How Can This Be Tested/Reviewed?
This can be tested by clicking through the form and ensuring that the form saves and applies the rental cost information entered whether you click previous on the disclaimer page or finish and see it reflected in the listings.
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.