Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min and Max rent filter fail if there are at least 4 digits #1632

Closed
ludtkemorgan opened this issue Aug 2, 2023 · 2 comments
Closed

Min and Max rent filter fail if there are at least 4 digits #1632

ludtkemorgan opened this issue Aug 2, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ludtkemorgan
Copy link
Collaborator

STEPS TO REPRODUCE:

  1. Go to the Detroit listings page and click on the filters
  2. Add at least a 4 digit number into either the Min or Max rent fields. (e.g 1000)
  3. No results will appear and an error shows on the backend
    filter.1.maxRent must be a number string

This is happening most likely because the front-end adds a comma after entering it and sends that to the backend. Also it appears to have started after the Aug 1st release

@KrissDrawing
Copy link
Collaborator

QA notes: on https://detroit-public-dev.netlify.app/listings click find rentals for you now filtering by numbers bigger that 1000 will send proper value (without comma), so it will filter as expected.
Should also work for: https://detroit-public-dev.netlify.app/listings/filtered and https://detroit-public-dev.netlify.app/finder filtering

@sarahlazarich
Copy link
Collaborator

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants