Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CLI build process #7

Merged
merged 5 commits into from
Feb 1, 2018
Merged

Simplify CLI build process #7

merged 5 commits into from
Feb 1, 2018

Conversation

revett
Copy link

@revett revett commented Feb 1, 2018

Problem

The CLI used to run the node is named differently to that of neo-python, and could be easier to build.

Solution

  • Rename output binary to neo-go to match naming of neo-python
  • Use make commands to simplify what anyone new to the project will have to do

Notes

  • None

@revett revett added the task Something to do label Feb 1, 2018
@revett revett requested a review from anthdm February 1, 2018 17:53
@anthdm
Copy link

anthdm commented Feb 1, 2018

Nice job, but wouldn't it be better to group all the binaries into a bin folder in the project root?

@revett revett merged commit 36335e5 into master Feb 1, 2018
@revett revett deleted the task/build-cli branch February 1, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthdm anthdm Awaiting requested review from anthdm

Assignees
No one assigned
Labels
task Something to do
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@revett @anthdm