-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: UI enhancements for unconfirmed transactions flow #1769
Merged
comountainclimber
merged 7 commits into
dev
from
feature/pending-transactions-ui-enhancements
Jan 6, 2019
Merged
feature: UI enhancements for unconfirmed transactions flow #1769
comountainclimber
merged 7 commits into
dev
from
feature/pending-transactions-ui-enhancements
Jan 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comountainclimber
changed the title
adds UI enhancements for unconfirmed transactions flow
feature: UI enhancements for unconfirmed transactions flow
Dec 31, 2018
dvd-schwrtz
approved these changes
Dec 31, 2018
evgenyboxer
reviewed
Jan 3, 2019
evgenyboxer
reviewed
Jan 3, 2019
evgenyboxer
reviewed
Jan 3, 2019
evgenyboxer
reviewed
Jan 3, 2019
evgenyboxer
approved these changes
Jan 3, 2019
…t for error message
…containers/App/Sidebar/index.js to reference PendingTransactions type
Pull Request Test Coverage Report for Build 5630
💛 - Coveralls |
comountainclimber
deleted the
feature/pending-transactions-ui-enhancements
branch
January 10, 2019 05:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
This PR is part II of #1766 and provides some subtle updates to the UI to help users understand the exact state of their unconfirmed transactions.
What problem does this PR solve?
Further improves our send UX
How did you solve this problem?
By extending the work started in #1766
How did you make sure your solution works?
Manual testing locally
Are there any special changes in the code that we should be aware of?
I updated
addPendingTransaction
to always return the retrieved information from the blockchain when adding a tx to storage so that the SideBar can know about only transactions returned fromgetRawTransaction
as opposed to every transaction that gets added to storage.Is there anything else we should know?