Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: adds watch only address (part I) #1845

Merged
merged 2 commits into from May 16, 2019
Merged

Conversation

comountainclimber
Copy link
Member

@comountainclimber comountainclimber commented May 13, 2019

watch-only

What current issue(s) from Trello/Github does this address?
#1827

(begins the process of tackling #1846)

This PR serves as a feature in itself however it is really the foundation of adding additional features such as building transactions for offline signing...

NOTE: more work needs to be done here (coming in separate PRs) to ensure high quality user experience in watch only mode (We should disable the appropriate routes and possibly address some other items I am not thinking of now)

What problem does this PR solve?
This gives the ability for users to enter in any valid address on the blockchain to use neon

How did you solve this problem?
By mostly reusing components and logic that already existed

How did you make sure your solution works?
Manual testing

Are there any special changes in the code that we should be aware of?
As mentioned previously there are things that will be broken with just this PR alone... Future work will refine the details that this lays the foundation for

Is there anything else we should know?

  • Unit tests written?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6113

  • 1 of 5 (20.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 39.848%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/actions/authActions.js 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
app/actions/nodeStorageActions.js 1 73.56%
Totals Coverage Status
Change from base Build 6099: -0.08%
Covered Lines: 1094
Relevant Lines: 2513

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants