feature: adds watch only address (part I) #1845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
#1827
(begins the process of tackling #1846)
This PR serves as a feature in itself however it is really the foundation of adding additional features such as building transactions for offline signing...
NOTE: more work needs to be done here (coming in separate PRs) to ensure high quality user experience in watch only mode (We should disable the appropriate routes and possibly address some other items I am not thinking of now)
What problem does this PR solve?
This gives the ability for users to enter in any valid address on the blockchain to use neon
How did you solve this problem?
By mostly reusing components and logic that already existed
How did you make sure your solution works?
Manual testing
Are there any special changes in the code that we should be aware of?
As mentioned previously there are things that will be broken with just this PR alone... Future work will refine the details that this lays the foundation for
Is there anything else we should know?