Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: adds watch only address (part II) #1847

Merged
merged 1 commit into from
May 16, 2019
Merged

feature: adds watch only address (part II) #1847

merged 1 commit into from
May 16, 2019

Conversation

comountainclimber
Copy link
Member

This is part II of #1845

Improving the UX by conditionally rendering certain side nav items based on authentication method.

Screen Shot 2019-05-13 at 4 53 15 PM

@comountainclimber comountainclimber changed the base branch from dev to feature/watch-address May 13, 2019 22:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6117

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 39.793%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/containers/App/Sidebar/Sidebar.jsx 1 2 50.0%
Totals Coverage Status
Change from base Build 6113: -0.05%
Covered Lines: 1094
Relevant Lines: 2514
💛 - Coveralls

@comountainclimber comountainclimber merged commit 7037a4c into feature/watch-address May 16, 2019
@comountainclimber comountainclimber deleted the feature/watch-address-II branch May 21, 2019 16:51
@comountainclimber comountainclimber mentioned this pull request May 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@comountainclimber @coveralls