Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: improve language setting UI #1964

Merged
merged 5 commits into from
Apr 11, 2020

Conversation

comountainclimber
Copy link
Member

lang-dropdown

(part of) #1963

@comountainclimber comountainclimber changed the base branch from dev to release/2.5.0 April 11, 2020 17:06
@coveralls
Copy link

coveralls commented Apr 11, 2020

Pull Request Test Coverage Report for Build 7207

  • 18 of 32 (56.25%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 41.867%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/containers/Settings/Settings.jsx 7 9 77.78%
app/components/Inputs/LanguageSelect/LanguageSelect.jsx 8 13 61.54%
app/core/constants.js 3 10 30.0%
Totals Coverage Status
Change from base Build 7191: 0.5%
Covered Lines: 1436
Relevant Lines: 3133

💛 - Coveralls

@comountainclimber comountainclimber merged commit 8ac695a into release/2.5.0 Apr 11, 2020
@comountainclimber comountainclimber deleted the feature/improve-lang-settings-ui branch April 11, 2020 21:40
comountainclimber added a commit that referenced this pull request Apr 14, 2020
* Updates LX hash

* Updates NEO and GAS logo assets

* Updates config.yml such that the windows config references electronuserland/builder:wine-01.19 (#1947)

* feature: Internationalization (#1933)

* First pass at gathering translations

* Adds more copy

* Adds react-intl

* Creates Intl wrapper component and begins implementation of translations

* Fixes key warning

* More translation implementation

* More translation implementation

* Updates snapshots fixes broken tests

* Adds language options to settings and state tree

* Fixes liting errors

* Fixes liting errors

* Adds translation support to CreateImportWalletForm.jsx

* Adds the korean translations for create/import wallet pages and login

* Updates snapshot tests and fixes flakey test

* Fixes broken tests

* Adds remaining korean and implements dashboard and sidebar translations

* Fixes flow and linting errors

* fixes linting issues

* Updates snapshot tests, test suite still failing

* Fixes broken test suite

* Updates settings view

* Updates progress panel HOC and encrypt form with translations

* Updates snapshot tests

* More translation additions and implementations

* Fixes broken tests and updates snapshots

* More translation implementation

* Fixes broken test

* Fixes broken test

* Cleans up buggy styles in WalletManager.scss

* Adds missing translations to import screen and finishes wallet manager translation implementation

* Updates snapshots

* Very close to full translation implementation

* Reverts changes to sketch file

* Fixes test suite

* Fixes linting errors

* Adds french translation file and settings constant

* Fixes small misc defects

* Updates snapshot tests

* Adds vietnamese translation file and settings constant

* Adds german translation file and settings constant

* Adds chinese to language options (#1949)

* feature: language setting dropdown (#1950)

* Squashes commits implements language option dropdown on home screen

* Updates snapshot tests

* Reverts unintentional changes

* Reverts unintentional changes

* Fixes linting error breaking CI

* audits npm deps for security issues (#1952)

* Updates package.json resolutions to fix numerous npm security warnings

* Updates package.json resolutions to fix numerous npm security warnings

* Updates package.json resolutions to fix numerous npm security warnings

* Fixes new linting errors introduces by dep upgrades

* Fixes new flow errors introduces by dep upgrades

* Fixes new linting errors introduces by dep upgrades

* Updates base docker image in config.yml

* Reverts changes to config.yml

* updates config.yml

* Try with --ignore-engines  flag

* Removes storybook and associated files (#1953)

* Removes storybook and associated files

* Adds --maxWorkers=10 flag to test command

* Adds --forceExit flag to test command

* attempting to debug circleCI timeout issue with --detectOpenHandles flag

* attempting to debug circleCI timeout issue with --detectOpenHandles flag

* More debugging nonsense

* More debugging nonsense

* updates test-ci command

* Adds back code coverage reporting

* remove --forceExit flag

* Reverts changes to code coverage upload

* Update README.md

* feature: Fixes broken dev build, cleans up dependency issues (#1955)

* Updates config.yml

* Cleans up issues in resolutions of package.json

* feature: updates core dependencies (where feasible) (#1956)

* Updates flow and react adds many instances of

* Renames deprecated lifecycle methods

* Fixes linting issues

* Fixes Sidebar.test.js

* Revert "feature: updates core dependencies (where feasible) (#1956)" (#1957)

This reverts commit 097df4b.

* feature: Fixes buggy CSS for network config tooltip (#1958)

* Fixes bug breaking layout and animations for NetworkConfigurationTooltip.jsx

* Updates snapshots

* Removes dead comment

* feature: final major round of translation polish (#1960)

* Implements missing translations in tooltip

* Adds missing translations and fixes various UI bugs

* Updates snapshots fixes broken tests

* Fixes broken test

* Updates snapshots

* More translation work

* Bumps version in package.json

* feature: improve language setting UI (#1964)

* Adds country flags to settings and login dropdowns

* Fixes flow errors

* Removes unused flag assets

* Adds unit tests for new component

* Fixes bug in Settings.jsx

* feature: implements feedback on release 2.5.0 (#1965)

* Adds missing translations, updates portuguese

* updates snapshots

* Adds additional missing translations

* Updates snapshots

* Finishes feedback implementation

* Adds missing tooltip translations to activity page

* Updates snapshots
comountainclimber added a commit that referenced this pull request Oct 7, 2020
* release: 2.5.0 (#1962)

* Updates LX hash

* Updates NEO and GAS logo assets

* Updates config.yml such that the windows config references electronuserland/builder:wine-01.19 (#1947)

* feature: Internationalization (#1933)

* First pass at gathering translations

* Adds more copy

* Adds react-intl

* Creates Intl wrapper component and begins implementation of translations

* Fixes key warning

* More translation implementation

* More translation implementation

* Updates snapshots fixes broken tests

* Adds language options to settings and state tree

* Fixes liting errors

* Fixes liting errors

* Adds translation support to CreateImportWalletForm.jsx

* Adds the korean translations for create/import wallet pages and login

* Updates snapshot tests and fixes flakey test

* Fixes broken tests

* Adds remaining korean and implements dashboard and sidebar translations

* Fixes flow and linting errors

* fixes linting issues

* Updates snapshot tests, test suite still failing

* Fixes broken test suite

* Updates settings view

* Updates progress panel HOC and encrypt form with translations

* Updates snapshot tests

* More translation additions and implementations

* Fixes broken tests and updates snapshots

* More translation implementation

* Fixes broken test

* Fixes broken test

* Cleans up buggy styles in WalletManager.scss

* Adds missing translations to import screen and finishes wallet manager translation implementation

* Updates snapshots

* Very close to full translation implementation

* Reverts changes to sketch file

* Fixes test suite

* Fixes linting errors

* Adds french translation file and settings constant

* Fixes small misc defects

* Updates snapshot tests

* Adds vietnamese translation file and settings constant

* Adds german translation file and settings constant

* Adds chinese to language options (#1949)

* feature: language setting dropdown (#1950)

* Squashes commits implements language option dropdown on home screen

* Updates snapshot tests

* Reverts unintentional changes

* Reverts unintentional changes

* Fixes linting error breaking CI

* audits npm deps for security issues (#1952)

* Updates package.json resolutions to fix numerous npm security warnings

* Updates package.json resolutions to fix numerous npm security warnings

* Updates package.json resolutions to fix numerous npm security warnings

* Fixes new linting errors introduces by dep upgrades

* Fixes new flow errors introduces by dep upgrades

* Fixes new linting errors introduces by dep upgrades

* Updates base docker image in config.yml

* Reverts changes to config.yml

* updates config.yml

* Try with --ignore-engines  flag

* Removes storybook and associated files (#1953)

* Removes storybook and associated files

* Adds --maxWorkers=10 flag to test command

* Adds --forceExit flag to test command

* attempting to debug circleCI timeout issue with --detectOpenHandles flag

* attempting to debug circleCI timeout issue with --detectOpenHandles flag

* More debugging nonsense

* More debugging nonsense

* updates test-ci command

* Adds back code coverage reporting

* remove --forceExit flag

* Reverts changes to code coverage upload

* Update README.md

* feature: Fixes broken dev build, cleans up dependency issues (#1955)

* Updates config.yml

* Cleans up issues in resolutions of package.json

* feature: updates core dependencies (where feasible) (#1956)

* Updates flow and react adds many instances of

* Renames deprecated lifecycle methods

* Fixes linting issues

* Fixes Sidebar.test.js

* Revert "feature: updates core dependencies (where feasible) (#1956)" (#1957)

This reverts commit 097df4b.

* feature: Fixes buggy CSS for network config tooltip (#1958)

* Fixes bug breaking layout and animations for NetworkConfigurationTooltip.jsx

* Updates snapshots

* Removes dead comment

* feature: final major round of translation polish (#1960)

* Implements missing translations in tooltip

* Adds missing translations and fixes various UI bugs

* Updates snapshots fixes broken tests

* Fixes broken test

* Updates snapshots

* More translation work

* Bumps version in package.json

* feature: improve language setting UI (#1964)

* Adds country flags to settings and login dropdowns

* Fixes flow errors

* Removes unused flag assets

* Adds unit tests for new component

* Fixes bug in Settings.jsx

* feature: implements feedback on release 2.5.0 (#1965)

* Adds missing translations, updates portuguese

* updates snapshots

* Adds additional missing translations

* Updates snapshots

* Finishes feedback implementation

* Adds missing tooltip translations to activity page

* Updates snapshots

* Adds updates assets, design elements and rebranding for dark theme

* Revert changes to notification autodismiss

* Comments out no longer relevant test

* Remove dead code

* Update webpack prod config to load new file format
comountainclimber added a commit that referenced this pull request Nov 10, 2020
* Update README.md (#1967)

* Russian localization (#1969)

* add russian localization

* fix tests

* Bump websocket-extensions from 0.1.3 to 0.1.4 (#1972)

Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4.
- [Release notes](https://github.com/faye/websocket-extensions-node/releases)
- [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md)
- [Commits](faye/websocket-extensions-node@0.1.3...0.1.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feature: implements dark theme reskin / add new font family (#1992)

* release: 2.5.0 (#1962)

* Updates LX hash

* Updates NEO and GAS logo assets

* Updates config.yml such that the windows config references electronuserland/builder:wine-01.19 (#1947)

* feature: Internationalization (#1933)

* First pass at gathering translations

* Adds more copy

* Adds react-intl

* Creates Intl wrapper component and begins implementation of translations

* Fixes key warning

* More translation implementation

* More translation implementation

* Updates snapshots fixes broken tests

* Adds language options to settings and state tree

* Fixes liting errors

* Fixes liting errors

* Adds translation support to CreateImportWalletForm.jsx

* Adds the korean translations for create/import wallet pages and login

* Updates snapshot tests and fixes flakey test

* Fixes broken tests

* Adds remaining korean and implements dashboard and sidebar translations

* Fixes flow and linting errors

* fixes linting issues

* Updates snapshot tests, test suite still failing

* Fixes broken test suite

* Updates settings view

* Updates progress panel HOC and encrypt form with translations

* Updates snapshot tests

* More translation additions and implementations

* Fixes broken tests and updates snapshots

* More translation implementation

* Fixes broken test

* Fixes broken test

* Cleans up buggy styles in WalletManager.scss

* Adds missing translations to import screen and finishes wallet manager translation implementation

* Updates snapshots

* Very close to full translation implementation

* Reverts changes to sketch file

* Fixes test suite

* Fixes linting errors

* Adds french translation file and settings constant

* Fixes small misc defects

* Updates snapshot tests

* Adds vietnamese translation file and settings constant

* Adds german translation file and settings constant

* Adds chinese to language options (#1949)

* feature: language setting dropdown (#1950)

* Squashes commits implements language option dropdown on home screen

* Updates snapshot tests

* Reverts unintentional changes

* Reverts unintentional changes

* Fixes linting error breaking CI

* audits npm deps for security issues (#1952)

* Updates package.json resolutions to fix numerous npm security warnings

* Updates package.json resolutions to fix numerous npm security warnings

* Updates package.json resolutions to fix numerous npm security warnings

* Fixes new linting errors introduces by dep upgrades

* Fixes new flow errors introduces by dep upgrades

* Fixes new linting errors introduces by dep upgrades

* Updates base docker image in config.yml

* Reverts changes to config.yml

* updates config.yml

* Try with --ignore-engines  flag

* Removes storybook and associated files (#1953)

* Removes storybook and associated files

* Adds --maxWorkers=10 flag to test command

* Adds --forceExit flag to test command

* attempting to debug circleCI timeout issue with --detectOpenHandles flag

* attempting to debug circleCI timeout issue with --detectOpenHandles flag

* More debugging nonsense

* More debugging nonsense

* updates test-ci command

* Adds back code coverage reporting

* remove --forceExit flag

* Reverts changes to code coverage upload

* Update README.md

* feature: Fixes broken dev build, cleans up dependency issues (#1955)

* Updates config.yml

* Cleans up issues in resolutions of package.json

* feature: updates core dependencies (where feasible) (#1956)

* Updates flow and react adds many instances of

* Renames deprecated lifecycle methods

* Fixes linting issues

* Fixes Sidebar.test.js

* Revert "feature: updates core dependencies (where feasible) (#1956)" (#1957)

This reverts commit 097df4b.

* feature: Fixes buggy CSS for network config tooltip (#1958)

* Fixes bug breaking layout and animations for NetworkConfigurationTooltip.jsx

* Updates snapshots

* Removes dead comment

* feature: final major round of translation polish (#1960)

* Implements missing translations in tooltip

* Adds missing translations and fixes various UI bugs

* Updates snapshots fixes broken tests

* Fixes broken test

* Updates snapshots

* More translation work

* Bumps version in package.json

* feature: improve language setting UI (#1964)

* Adds country flags to settings and login dropdowns

* Fixes flow errors

* Removes unused flag assets

* Adds unit tests for new component

* Fixes bug in Settings.jsx

* feature: implements feedback on release 2.5.0 (#1965)

* Adds missing translations, updates portuguese

* updates snapshots

* Adds additional missing translations

* Updates snapshots

* Finishes feedback implementation

* Adds missing tooltip translations to activity page

* Updates snapshots

* Adds updates assets, design elements and rebranding for dark theme

* Revert changes to notification autodismiss

* Comments out no longer relevant test

* Remove dead code

* Update webpack prod config to load new file format

* Fix french language translation (#1978)

* Fix french language translation

* Fix Francés to Français

* Bump http-proxy from 1.18.0 to 1.18.1 (#1987)

Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.18.0 to 1.18.1.
- [Release notes](https://github.com/http-party/node-http-proxy/releases)
- [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md)
- [Commits](http-party/node-http-proxy@1.18.0...1.18.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump node-sass from 4.12.0 to 4.13.1 (#1986)

Bumps [node-sass](https://github.com/sass/node-sass) from 4.12.0 to 4.13.1.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](sass/node-sass@v4.12.0...v4.13.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feature: implement light theme reskin (#1995)

* Completes first pass at light theme reskin

* Update snapshots

* Revert unintentional changes

* feature: updates electron to version 8.5.2 (#1996)

* Bumps electron version to 8.5.2 and fixes layout issues on Dashboard

* Updates yarn.lock

* Updates .flowconfig

* Fix build script

* update deploy_win64 script

* Bump @ledgerhq/hw-transport-node-hid

* Bump @ledgerhq/hw-transport-node-hid

* Reverts changes to @ledgerhq/hw-transport-node-hid version

* adds usb_bindings.node and updates dependency list

* Updates flow type checking in neonLedger.js

* Refactor /ledger, fix broken tests, finally sort out deps

* Fix typos

* Adds usb as an external module in webpack config

* Fixes flow error

* Reverts flow fix

* feature: implement button reskin (#2000)

* Implements button redesign

* Update snapshots

* feature: misc enhancements for release 2.6.0 (#2001)

* Updates image asset in LogoWithStrikethrough.jsx

* Update webpack and webpack-dev-server

* Various CSS bug fixes introduced with electron upgrade

* Updates icon and background assets

* Update dark theme colors, adds conditional logo in LogoWithStrikethrough.jsx updates dmg splashscreen background

* fix wallet export/import (#2002)

* fix wallet export

* fix wallet recovery import

* Update app/containers/Settings/Settings.jsx

Co-authored-by: Maxwell Lasky <mlasky46@gmail.com>

* fix failed Github suggestion

Co-authored-by: Maxwell Lasky <mlasky46@gmail.com>

* feature: Sets up auto update for Linux/Windows/MacOS and and code signing/notarization on MacOS [WIP] (#2003)

* Set up auto update and code signing

* Removes extra dotenv dep

* Override default artifact naming convention

* feature: CI enhancements (#2004)

* test commit

* update dist command

* update config.yml

* update config.yml

* Fix publish script

* update pack

* test commit

* Bump version

* refactor config.yml

* refactor config.yml

* Revert unintentional changes

* Revert unintentional changes

* Remove publish script

* Add back author key

* Fixes issues with FullHeightPanel.jsx (#2005)

* feature: fix reskin button design (#2007)

* Fixes dark theme primary disabled button styles

* Fix font loading bugs and input color on dark theme

* remove dead fonts

* create and implement secondary elevated button

* Updates button styles

* Remove commented code

* feature: beta release feedback (#2008)

* Implements numeruous design enhancements, fixes activity export

* Updates snapshots

* Fix icon color in wallet manager

* Massive amounts of design polish on both themes and many components

* Lint and fix snapshots

* Clean up dead code

* Clean up dead code

* Clean up dead code

* lint

* Fix snapshots

* feature: Adds release notes component / rendering logic (#2006)

* Set updateDownloaded flag

* feature: release notes modal (#2009)

* feature: fix reskin button design (#2007)

* Fixes dark theme primary disabled button styles

* Fix font loading bugs and input color on dark theme

* remove dead fonts

* create and implement secondary elevated button

* Updates button styles

* Remove commented code

* feature: beta release feedback (#2008)

* Implements numeruous design enhancements, fixes activity export

* Updates snapshots

* Fix icon color in wallet manager

* Massive amounts of design polish on both themes and many components

* Lint and fix snapshots

* Clean up dead code

* Clean up dead code

* Clean up dead code

* lint

* Fix snapshots

* Sets up logic and finishes implementation of release notes modal

* update snapshots

* conditionally render notes once when running 2.6.0

* Simplify release notes render

* Hide release render for now

* update package.json

* Updates config.yml (#2010)

* feature: various release enhancements (#2011)

* app wide release enhancements

* Updates snapshots

* Fixes button style in QR scanner

* Only render new release notification on Linux

* lint

* Update metadata.js

* remove commented out code

* Feature/panel color update (#2012)

* Update light theme receive panel color

* Update snapshots

* Adds network config reset flow, updates dmg background, updates icon color in nothing.svg, adds github button to release notes

* Removes dead code

* Updates snapshots

* Removes dead code

* Fixes button label inconsistencies

Co-authored-by: Oleg Smirnov <smirnov.os@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Fabian Vilers <fabian.vilers@dev-one.com>
Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants