Add Cut/Copy/Paste context menus on input fields (#336) #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsaulnier
changed the title
|
I am not seeing any difference to the copy and paste functionality when I use these changes. What does it mean that it adds a context menu? @evgenyboxer can you also take a look at this |
|
@dvdschwrtz I updated my PR comment, a right click on input elements should display a menu with cut / copy / past / select all options |
| @@ -80,6 +80,17 @@ app.on('ready', () => { | |||
| Menu.setApplicationMenu(menu) | |||
| } | |||
|
|
|||
| const inputMenu = Menu.buildFromTemplate([ | |||
There was a problem hiding this comment.
per our slack discussion, please change to only allow for 'paste'. thanks and look forward to working with you on the wallet :)
There was a problem hiding this comment.
@dvdschwrtz done 👌
dvdschwrtz-zz
approved these changes
Dec 1, 2017
dvdschwrtz-zz
pushed a commit
that referenced
this pull request
Dec 2, 2017
* Fix for: Password is displayed as visible text when creating wallet #342 (#347) * Fix for: Give warning when API is down or wallet lacks connectivity #265 (#346) * Fix lint errors and refactor * Remove RPX from reducers * Move loading indicator to the top * hide scrollbars * finetune the buttons * Move the refresh button code to Dashboard.scss * Remove unused styles * Split token balances into its own component * Add info icon * add tokens balance to initiateGetBalance * Remove unused methods * POC tokenInfo * Use PasswordField for WIF key in secret token sale screen (#351) * Add token info modal and refactor the tokens state * Update snapshots * Remove uneeded code * Better formatting (#350) * Better formatting for bigger numbers * Formating formatters file * Removing mime requirement. Not needed. * Remove exclamation that's not needed in UI (#353) * Enter in textfields submits alt (#354) * Enter button submits forms, simple solution * Code style fixes * Use tight version * Remove unused function * Remove comment * Remove ToggleAsset * Rename Gas -> GAS / Neo -> NEO * Add isToken method * WIP * Use tight versioning * WIP * Rename rpx to sale, and clean it up * Rename reducers to index * Fix paths * Add flow * Add flow * cleanups * Rename initiateGetBalance to LoadWalletData * Add TokenInfo type * Fix tests * Refactor prices (to support in the future) * Add Type suffix for types * Cleanup * Cleanup * Cleanup * Fix typo * Use neon-js constants * Add support for test tokens * Add percent buttons * Fix token sale * Sort imports * Fix typo * Revert back to not using NeonJS for Network * Remove unsued functions * Fix lint errors * Refactor explorer * Fix typo * Revert back to local consts for ASSETS * Load info when modal loads * Rename to openExplorerTx * Pass retrieveTokenInfo to the token info modal * WIP * Change token to symbol * Add flow-typed for npm modules * Move declarations upper level * Correct GAS decimal length * Fix token info modal * Symbol > Asset * Add a border to the dashboard * Disable claim when claim amount is 0 * Fix lint errors * Fix recieve modal height * format balance * Preload token info when getting token balance (if it doesn't exist) * Refactor formatters * Drop the state and grab the info from the token props * Add number formatting * Use truncateToken * Rename formatNumber to formatBalance * Fix obtainTokenBalance * Increase modal size to show full address * Fix sending NEO/GAS * Remove unused functions/reducers * Remove unused state * Fix CopyToClipboard + Tooltips * hash lint error for now * Fix creating a new wallet * es6 * fixes private key verification * fix reset prices * Wif > WIF * validatePassphrase > validatePassphraseLengthLength * Consolidate wallet creation * Consolidate CreateWallet/EncryptKey * WIF -> encryptedWIF * Remove checkMatchingPassphrases and rename validatePassphrase * Remove async and and a check for the validity of the encrypted wif * remove unused style * WIP * Load settings on app init (#377) * Don't run coveralls when pushing (#379) * Don't run coveralls on local * Cleaner solution for: Don't run coveralls on local * Use new test-ci command for ci * Support for non-USD Currencies (#378) * Configurable currencies * Missed settings in the merge resolution commit * Fix lint issue * Add Cut/Copy/Paste context menus on input fields (#336) (#376) * #336 * Allow for 'paste' only * Resolve conflicts * Use neon-js cnc api * uppercase GAS and NEO * update snapshots * Capitlize
dvdschwrtz-zz
pushed a commit
that referenced
this pull request
Dec 2, 2017
* Fix for: Password is displayed as visible text when creating wallet #342 (#347) * Fix for: Give warning when API is down or wallet lacks connectivity #265 (#346) * Fix lint errors and refactor * Remove RPX from reducers * Move loading indicator to the top * hide scrollbars * finetune the buttons * Move the refresh button code to Dashboard.scss * Remove unused styles * Split token balances into its own component * Add info icon * add tokens balance to initiateGetBalance * Remove unused methods * POC tokenInfo * Use PasswordField for WIF key in secret token sale screen (#351) * Add token info modal and refactor the tokens state * Update snapshots * Remove uneeded code * Better formatting (#350) * Better formatting for bigger numbers * Formating formatters file * Removing mime requirement. Not needed. * Remove exclamation that's not needed in UI (#353) * Enter in textfields submits alt (#354) * Enter button submits forms, simple solution * Code style fixes * Use tight version * Remove unused function * Remove comment * Remove ToggleAsset * Rename Gas -> GAS / Neo -> NEO * Add isToken method * WIP * Use tight versioning * WIP * Rename rpx to sale, and clean it up * Rename reducers to index * Fix paths * Add flow * Add flow * cleanups * Rename initiateGetBalance to LoadWalletData * Add TokenInfo type * Fix tests * Refactor prices (to support in the future) * Add Type suffix for types * Cleanup * Cleanup * Cleanup * Fix typo * Use neon-js constants * Add support for test tokens * Add percent buttons * Fix token sale * Sort imports * Fix typo * Revert back to not using NeonJS for Network * Remove unsued functions * Fix lint errors * Refactor explorer * Fix typo * Revert back to local consts for ASSETS * Load info when modal loads * Rename to openExplorerTx * Pass retrieveTokenInfo to the token info modal * WIP * Change token to symbol * Add flow-typed for npm modules * Move declarations upper level * Correct GAS decimal length * Fix token info modal * Symbol > Asset * Add a border to the dashboard * Disable claim when claim amount is 0 * Fix lint errors * Fix recieve modal height * format balance * Preload token info when getting token balance (if it doesn't exist) * Refactor formatters * Drop the state and grab the info from the token props * Add number formatting * Use truncateToken * Rename formatNumber to formatBalance * Fix obtainTokenBalance * Increase modal size to show full address * Fix sending NEO/GAS * Remove unused functions/reducers * Remove unused state * Fix CopyToClipboard + Tooltips * hash lint error for now * Fix creating a new wallet * es6 * fixes private key verification * fix reset prices * Wif > WIF * validatePassphrase > validatePassphraseLengthLength * Consolidate wallet creation * Consolidate CreateWallet/EncryptKey * WIF -> encryptedWIF * Remove checkMatchingPassphrases and rename validatePassphrase * Remove async and and a check for the validity of the encrypted wif * remove unused style * WIP * Load settings on app init (#377) * Don't run coveralls when pushing (#379) * Don't run coveralls on local * Cleaner solution for: Don't run coveralls on local * Use new test-ci command for ci * Support for non-USD Currencies (#378) * Configurable currencies * Missed settings in the merge resolution commit * Fix lint issue * Add Cut/Copy/Paste context menus on input fields (#336) (#376) * #336 * Allow for 'paste' only * Resolve conflicts * Use neon-js cnc api * uppercase GAS and NEO * update snapshots * Capitlize * Remove set token info * Correct SymbolType/TokenType * Update symbol type * Add a missing onClick * Use React$Node * Rework formatting * Use the correct function * Add cleave.js and update neon-js * Extract the nep5 decimal adjust to a util, and support ledger transfer (WIP) * Update types * Add a silent flag * WIP * Fix formatting
dvdschwrtz-zz
pushed a commit
that referenced
this pull request
Dec 3, 2017
* Fix for: Password is displayed as visible text when creating wallet #342 (#347) * Fix for: Give warning when API is down or wallet lacks connectivity #265 (#346) * Use PasswordField for WIF key in secret token sale screen (#351) * Better formatting (#350) * Better formatting for bigger numbers * Formating formatters file * Removing mime requirement. Not needed. * Remove exclamation that's not needed in UI (#353) * Enter in textfields submits alt (#354) * Enter button submits forms, simple solution * Code style fixes * Load settings on app init (#377) * Don't run coveralls when pushing (#379) * Don't run coveralls on local * Cleaner solution for: Don't run coveralls on local * Use new test-ci command for ci * Support for non-USD Currencies (#378) * Configurable currencies * Missed settings in the merge resolution commit * Fix lint issue * Add Cut/Copy/Paste context menus on input fields (#336) (#376) * #336 * Allow for 'paste' only * fix issues post merge conflict resolution * fix merge conflicts with test
dvdschwrtz-zz
pushed a commit
that referenced
this pull request
Dec 3, 2017
…382) * Fix for: Password is displayed as visible text when creating wallet #342 (#347) * Fix for: Give warning when API is down or wallet lacks connectivity #265 (#346) * Use PasswordField for WIF key in secret token sale screen (#351) * Better formatting (#350) * Better formatting for bigger numbers * Formating formatters file * Removing mime requirement. Not needed. * Remove exclamation that's not needed in UI (#353) * Enter in textfields submits alt (#354) * Enter button submits forms, simple solution * Code style fixes * Load settings on app init (#377) * Don't run coveralls when pushing (#379) * Don't run coveralls on local * Cleaner solution for: Don't run coveralls on local * Use new test-ci command for ci * Support for non-USD Currencies (#378) * Configurable currencies * Missed settings in the merge resolution commit * Fix lint issue * Add Cut/Copy/Paste context menus on input fields (#336) (#376) * #336 * Allow for 'paste' only * Extra instructions to help people having issues installing node-hid * Remerging dev to try to preserve history * Some more merge improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
#336
What problem does this PR solve?
Right Click on input doesn't do anything. You should see a menu with cut / copy / past / select all options
How did you solve this problem?
Add Electron menu input config
How did you make sure your solution works?
Tests
Are there any special changes in the code that we should be aware of?
Is there anything else we should know?