Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run coveralls when pushing #379

Merged
merged 3 commits into from
Dec 1, 2017
Merged

Don't run coveralls when pushing #379

merged 3 commits into from
Dec 1, 2017

Conversation

slipo
Copy link
Contributor

@slipo slipo commented Dec 1, 2017

What current issue(s) from Trello/Github does this address?
None

What problem does this PR solve?
Currently when you push to the repo it tries to run coveralls coverage test and gives this error:

neon-wallet/node_modules/coveralls/bin/coveralls.js:18
        throw err;
        ^
Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true}

How did you solve this problem?
Don't run try to trigger coveralls locally

How did you make sure your solution works?
Pushed this branch, didn't have to use '--no-verify'

Are there any special changes in the code that we should be aware of?
No

Is there anything else we should know?
For some more information:
nickmerwin/node-coveralls#166

  • Unit tests written?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.474% when pulling 06979a1 on slipo:no-coveralls-local into 921cabe on CityOfZion:dev.

@slipo
Copy link
Contributor Author

slipo commented Dec 1, 2017

Just pushed a nicer version which allows us to continue using yarn test locally... For this to work, somebody needs to change the Circle CI build configurations to use yarn test-ci instead of yarn test

@shawnmclean
Copy link
Contributor

@slipo you can also make this change in the /.circleci/config.yml file.

@slipo
Copy link
Contributor Author

slipo commented Dec 1, 2017

ahh cool, didn't realize. done.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.474% when pulling 588422f on slipo:no-coveralls-local into 921cabe on CityOfZion:dev.

@shawnmclean shawnmclean merged commit 1af9c92 into CityOfZion:dev Dec 1, 2017
@slipo slipo deleted the no-coveralls-local branch December 1, 2017 19:06
dvdschwrtz-zz pushed a commit that referenced this pull request Dec 2, 2017
@evgenyboxer @dvdschwrtz
NEP5 (#380)
2dbc24a 
* Fix for: Password is displayed as visible text when creating wallet #342 (#347)

* Fix for: Give warning when API is down or wallet lacks connectivity #265 (#346)

* Fix lint errors and refactor

* Remove RPX from reducers

* Move loading indicator to the top

* hide scrollbars

* finetune the buttons

* Move the refresh button code to Dashboard.scss

* Remove unused styles

* Split token balances into its own component

* Add info icon

* add tokens balance to initiateGetBalance

* Remove unused methods

* POC tokenInfo

* Use PasswordField for WIF key in secret token sale screen (#351)

* Add token info modal and refactor the tokens state

* Update snapshots

* Remove uneeded code

* Better formatting (#350)

* Better formatting for bigger numbers

* Formating formatters file

* Removing mime requirement. Not needed.

* Remove exclamation that's not needed in UI (#353)

* Enter in textfields submits alt (#354)

* Enter button submits forms, simple solution

* Code style fixes

* Use tight version

* Remove unused function

* Remove comment

* Remove ToggleAsset

* Rename Gas -> GAS / Neo -> NEO

* Add isToken method

* WIP

* Use tight versioning

* WIP

* Rename rpx to sale, and clean it up

* Rename reducers to index

* Fix paths

* Add flow

* Add flow

* cleanups

* Rename initiateGetBalance to LoadWalletData

* Add TokenInfo type

* Fix tests

* Refactor prices (to support in the future)

* Add Type suffix for types

* Cleanup

* Cleanup

* Cleanup

* Fix typo

* Use neon-js constants

* Add support for test tokens

* Add percent buttons

* Fix token sale

* Sort imports

* Fix typo

* Revert back to not using NeonJS for Network

* Remove unsued functions

* Fix lint errors

* Refactor explorer

* Fix typo

* Revert back to local consts for ASSETS

* Load info when modal loads

* Rename to openExplorerTx

* Pass retrieveTokenInfo to the token info modal

* WIP

* Change token to symbol

* Add flow-typed for npm modules

* Move declarations upper level

* Correct GAS decimal length

* Fix token info modal

* Symbol > Asset

* Add a border to the dashboard

* Disable claim when claim amount is 0

* Fix lint errors

* Fix recieve modal height

* format balance

* Preload token info when getting token balance (if it doesn't exist)

* Refactor formatters

* Drop the state and grab the info from the token props

* Add number formatting

* Use truncateToken

* Rename formatNumber to formatBalance

* Fix obtainTokenBalance

* Increase modal size to show full address

* Fix sending NEO/GAS

* Remove unused functions/reducers

* Remove unused state

* Fix CopyToClipboard + Tooltips

* hash lint error for now

* Fix creating a new wallet

* es6

* fixes private key verification

* fix reset prices

* Wif > WIF

* validatePassphrase > validatePassphraseLengthLength

* Consolidate wallet creation

* Consolidate CreateWallet/EncryptKey

* WIF -> encryptedWIF

* Remove checkMatchingPassphrases and rename validatePassphrase

* Remove async and and a check for the validity of the encrypted wif

* remove unused style

* WIP

* Load settings on app init (#377)

* Don't run coveralls when pushing (#379)

* Don't run coveralls on local

* Cleaner solution for: Don't run coveralls on local

* Use new test-ci command for ci

* Support for non-USD Currencies (#378)

* Configurable currencies

* Missed settings in the merge resolution commit

* Fix lint issue

* Add Cut/Copy/Paste context menus on input fields (#336) (#376)

* #336

* Allow for 'paste' only

* Resolve conflicts

* Use neon-js cnc api

* uppercase GAS and NEO

* update snapshots

* Capitlize
dvdschwrtz-zz pushed a commit that referenced this pull request Dec 2, 2017
@evgenyboxer @dvdschwrtz
NEP5 (#381)
f680874 
* Fix for: Password is displayed as visible text when creating wallet #342 (#347)

* Fix for: Give warning when API is down or wallet lacks connectivity #265 (#346)

* Fix lint errors and refactor

* Remove RPX from reducers

* Move loading indicator to the top

* hide scrollbars

* finetune the buttons

* Move the refresh button code to Dashboard.scss

* Remove unused styles

* Split token balances into its own component

* Add info icon

* add tokens balance to initiateGetBalance

* Remove unused methods

* POC tokenInfo

* Use PasswordField for WIF key in secret token sale screen (#351)

* Add token info modal and refactor the tokens state

* Update snapshots

* Remove uneeded code

* Better formatting (#350)

* Better formatting for bigger numbers

* Formating formatters file

* Removing mime requirement. Not needed.

* Remove exclamation that's not needed in UI (#353)

* Enter in textfields submits alt (#354)

* Enter button submits forms, simple solution

* Code style fixes

* Use tight version

* Remove unused function

* Remove comment

* Remove ToggleAsset

* Rename Gas -> GAS / Neo -> NEO

* Add isToken method

* WIP

* Use tight versioning

* WIP

* Rename rpx to sale, and clean it up

* Rename reducers to index

* Fix paths

* Add flow

* Add flow

* cleanups

* Rename initiateGetBalance to LoadWalletData

* Add TokenInfo type

* Fix tests

* Refactor prices (to support in the future)

* Add Type suffix for types

* Cleanup

* Cleanup

* Cleanup

* Fix typo

* Use neon-js constants

* Add support for test tokens

* Add percent buttons

* Fix token sale

* Sort imports

* Fix typo

* Revert back to not using NeonJS for Network

* Remove unsued functions

* Fix lint errors

* Refactor explorer

* Fix typo

* Revert back to local consts for ASSETS

* Load info when modal loads

* Rename to openExplorerTx

* Pass retrieveTokenInfo to the token info modal

* WIP

* Change token to symbol

* Add flow-typed for npm modules

* Move declarations upper level

* Correct GAS decimal length

* Fix token info modal

* Symbol > Asset

* Add a border to the dashboard

* Disable claim when claim amount is 0

* Fix lint errors

* Fix recieve modal height

* format balance

* Preload token info when getting token balance (if it doesn't exist)

* Refactor formatters

* Drop the state and grab the info from the token props

* Add number formatting

* Use truncateToken

* Rename formatNumber to formatBalance

* Fix obtainTokenBalance

* Increase modal size to show full address

* Fix sending NEO/GAS

* Remove unused functions/reducers

* Remove unused state

* Fix CopyToClipboard + Tooltips

* hash lint error for now

* Fix creating a new wallet

* es6

* fixes private key verification

* fix reset prices

* Wif > WIF

* validatePassphrase > validatePassphraseLengthLength

* Consolidate wallet creation

* Consolidate CreateWallet/EncryptKey

* WIF -> encryptedWIF

* Remove checkMatchingPassphrases and rename validatePassphrase

* Remove async and and a check for the validity of the encrypted wif

* remove unused style

* WIP

* Load settings on app init (#377)

* Don't run coveralls when pushing (#379)

* Don't run coveralls on local

* Cleaner solution for: Don't run coveralls on local

* Use new test-ci command for ci

* Support for non-USD Currencies (#378)

* Configurable currencies

* Missed settings in the merge resolution commit

* Fix lint issue

* Add Cut/Copy/Paste context menus on input fields (#336) (#376)

* #336

* Allow for 'paste' only

* Resolve conflicts

* Use neon-js cnc api

* uppercase GAS and NEO

* update snapshots

* Capitlize

* Remove set token info

* Correct SymbolType/TokenType

* Update symbol type

* Add a missing onClick

* Use React$Node

* Rework formatting

* Use the correct function

* Add cleave.js and update neon-js

* Extract the nep5 decimal adjust to a util, and support ledger transfer (WIP)

* Update types

* Add a silent flag

* WIP

* Fix formatting
dvdschwrtz-zz pushed a commit that referenced this pull request Dec 3, 2017
@dvdschwrtz
Nep5 (#385)
be26770 
* Fix for: Password is displayed as visible text when creating wallet #342 (#347)

* Fix for: Give warning when API is down or wallet lacks connectivity #265 (#346)

* Use PasswordField for WIF key in secret token sale screen (#351)

* Better formatting (#350)

* Better formatting for bigger numbers

* Formating formatters file

* Removing mime requirement. Not needed.

* Remove exclamation that's not needed in UI (#353)

* Enter in textfields submits alt (#354)

* Enter button submits forms, simple solution

* Code style fixes

* Load settings on app init (#377)

* Don't run coveralls when pushing (#379)

* Don't run coveralls on local

* Cleaner solution for: Don't run coveralls on local

* Use new test-ci command for ci

* Support for non-USD Currencies (#378)

* Configurable currencies

* Missed settings in the merge resolution commit

* Fix lint issue

* Add Cut/Copy/Paste context menus on input fields (#336) (#376)

* #336

* Allow for 'paste' only

* fix issues post merge conflict resolution

* fix merge conflicts with test
dvdschwrtz-zz pushed a commit that referenced this pull request Dec 3, 2017
@slipo @dvdschwrtz
Extra instructions to help people having issues installing node-hid (#…
4a86bfc 
…382)

* Fix for: Password is displayed as visible text when creating wallet #342 (#347)

* Fix for: Give warning when API is down or wallet lacks connectivity #265 (#346)

* Use PasswordField for WIF key in secret token sale screen (#351)

* Better formatting (#350)

* Better formatting for bigger numbers

* Formating formatters file

* Removing mime requirement. Not needed.

* Remove exclamation that's not needed in UI (#353)

* Enter in textfields submits alt (#354)

* Enter button submits forms, simple solution

* Code style fixes

* Load settings on app init (#377)

* Don't run coveralls when pushing (#379)

* Don't run coveralls on local

* Cleaner solution for: Don't run coveralls on local

* Use new test-ci command for ci

* Support for non-USD Currencies (#378)

* Configurable currencies

* Missed settings in the merge resolution commit

* Fix lint issue

* Add Cut/Copy/Paste context menus on input fields (#336) (#376)

* #336

* Allow for 'paste' only

* Extra instructions to help people having issues installing node-hid

* Remerging dev to try to preserve history

* Some more merge improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slipo @coveralls @shawnmclean