Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Factory Overflow #394

Merged
merged 2 commits into from
May 1, 2024
Merged

Fix Factory Overflow #394

merged 2 commits into from
May 1, 2024

Conversation

MrJeremyFisher
Copy link
Contributor

Fixes FactoryMod incorrectly believing that recipe output would fit in a chest because of some incorrect uses of ItemMap's fitsIn and an issue with fitsIn itself.

okx-code
okx-code approved these changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@okx-code okx-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@AngrySoundTech AngrySoundTech added this to the 1.27.0 - Next Update milestone May 1, 2024
@RedDevel2 RedDevel2 merged commit 6f1690f into CivMC:main May 1, 2024
2 checks passed
okx-code added a commit that referenced this pull request May 8, 2024
@okx-code
Revert "Merge pull request #394 from MrJeremyFisher/maybe-fix-factory…
b52671a 
…-overflow"

This reverts commit 6f1690f, reversing
changes made to 314a693.
okx-code added a commit that referenced this pull request May 8, 2024
@okx-code
Merge pull request #494 from CivMC/revert-factorymod
854e657 
Revert "Merge pull request #394 from MrJeremyFisher/maybe-fix-factory…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okx-code okx-code okx-code approved these changes

Assignees

@MrJeremyFisher MrJeremyFisher

Labels
Category: Bug Priority: High
Projects
CivMC Roadmap
Archived in project
Milestone
1.27.0 - Next Update
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrJeremyFisher @okx-code @AngrySoundTech @RedDevel2