Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wexpansion-to-defined in drivers/vhost/vhost.c #508

Closed
nathanchance opened this issue Jun 6, 2019 · 2 comments
Closed

-Wexpansion-to-defined in drivers/vhost/vhost.c #508

nathanchance opened this issue Jun 6, 2019 · 2 comments
Assignees
@nathanchance
Labels
-Wexpansion-to-defined [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle

Comments

@nathanchance
Copy link
Member 

drivers/vhost/vhost.c:2085:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined]
#if VHOST_ARCH_CAN_ACCEL_UACCESS
    ^
drivers/vhost/vhost.h:98:38: note: expanded from macro 'VHOST_ARCH_CAN_ACCEL_UACCESS'
#define VHOST_ARCH_CAN_ACCEL_UACCESS defined(CONFIG_MMU_NOTIFIER) && \
                                     ^

Patch sent: https://lore.kernel.org/lkml/20190606161223.67979-1-natechancellor@gmail.com/
@nathanchance nathanchance added [PATCH] Submitted A patch has been submitted for review [BUG] linux-next This is an issue only seen in linux-next -Wexpansion-to-defined labels Jun 6, 2019
@nathanchance nathanchance self-assigned this Jun 6, 2019
@nathanchance
Copy link
Member Author

The maintainer wanted the fix done a bit of a different way, which still works.

https://git.kernel.org/mst/vhost/c/0b4a7092ffe568a55bf8f3cefdf79ff666586d91

@nathanchance nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Jun 6, 2019
@nathanchance
Copy link
Member Author

Fixed: https://git.kernel.org/next/linux-next/c/0b4a7092ffe568a55bf8f3cefdf79ff666586d91

@nathanchance nathanchance added [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wexpansion-to-defined [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanchance