Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current quest file format is not git-friendly #93

Closed
KatatsumuriPan opened this issue Feb 20, 2024 · 3 comments
Closed

Current quest file format is not git-friendly #93

KatatsumuriPan opened this issue Feb 20, 2024 · 3 comments

Comments

@KatatsumuriPan
Copy link

Removing quest causes the commit to become too large.
This is an example.

To fix it, I suggest using NBTTagCompound keyed by questID instead of NBTTagList.
This changes the format of the quest file(DefaultQuests.json) and breaks forward compatibility.

@KatatsumuriPan
Copy link
Author

Additionally, I don't think BQ's unique file format is human-friendly.
I recommend using Key-Sorted-SNBT.(original SNBT keys are randomly sorted...)

@KatatsumuriPan
Copy link
Author

Furthermore, splitting quest files like gtnh is better.

@WaitingIdly
Copy link
Collaborator

resolved by #111 splitting quest files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants