Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opens a blank tab when clicking outside links on Reddit. #14

Closed
Stealth3 opened this issue Nov 26, 2017 · 9 comments
Closed

Opens a blank tab when clicking outside links on Reddit. #14

Stealth3 opened this issue Nov 26, 2017 · 9 comments
Assignees

Comments

@Stealth3
Copy link

If I click a link to another site on Reddit it just opens a blank website (about:blank in the url bar). It works though if I right click on the link and open it.

@KevinRoebert
Copy link
Member

Hi, can you give an example url?

@Stealth3
Copy link
Author

Stealth3 commented Nov 30, 2017

https://www.reddit.com/r/thewalkingdead/

or go to any subreddit.

Find a link to an outside site (Maggie Grace joins Fear The Walking Dead Season 4) (http://www.comingsoon.net/tv/news/906113-maggie-grace-joins-fear-the-walking-dead-season-4)

I click it and it just opens about:blank.

@grahamperrin
Copy link

Environment

Waterfox 56.0 on FreeBSD-CURRENT

[grahamperrin@momh167-gjp4-hpelitebook8570p-freebsd] ~% date ; uname -v
Fri  8 Dec 2017 03:00:59 GMT
FreeBSD 12.0-CURRENT #0 r320869: Mon Jul 10 13:57:55 UTC 2017     root@releng3.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC 
[grahamperrin@momh167-gjp4-hpelitebook8570p-freebsd] ~% pkg info waterfox | grep -i version
Version        : 56.0.s20171203
[grahamperrin@momh167-gjp4-hpelitebook8570p-freebsd] ~% 

Steps to produce an empty page – not about:blank

  1. https://www.reddit.com/r/firefox/comments/7cqeng/webassembly_support_now_shipping_in_all_major/
  2. Control-Click the linked phrase, WebAssembly support now shipping in all major browsers

Expected

Actual result

Workaround

  • switch off the Filters feature of ClearURLs 1.1.2.5
  • reload the referring (Reddit) page, repeat steps (1) and (2).

@KevinRoebert
Copy link
Member

Does it help?

@Stealth3
Copy link
Author

Stealth3 commented Dec 8, 2017

Does what help? There was no update to the add-on.

@KevinRoebert
Copy link
Member

Does what help? There was no update to the add-on.

This was the update...

KevinRoebert closed this in 4025f6b 7 hours ago

@Thorin-Oakenpants
Copy link

FYI: using @grahamperrin steps to reproduce & ClearURLs 1.1.2.5

With ClearURLs disabled, I get the same behavior. So the fix seems to be working - thanks

@Stealth3
Copy link
Author

Stealth3 commented Dec 9, 2017

It's working correctly now for me it seems! I tried turning off the filters before and turning them back on (to manually update them? not sure if that works) and it didn't fix anything. I tried it again and restarted the browser and now Reddit links seem to be working as intended. I'm glad graham could explain my issue in great depth and thank you Kevin for fixing it!

Edit: I was half asleep when I first read your comment Kevin and thought you said "there was an update". Am I to believe that nothing has changed though actually and it just started working for some reason for me?

@KevinRoebert
Copy link
Member

ClearURLs load the new rule file only on browser start :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants