Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoke should dissipate outside of reality bubble, ie: car exhaust. #23240

Closed
mrkybe opened this issue Mar 18, 2018 · 1 comment · Fixed by #23241
Closed

Smoke should dissipate outside of reality bubble, ie: car exhaust. #23240

mrkybe opened this issue Mar 18, 2018 · 1 comment · Fixed by #23241
Labels
<Enhancement / Feature> New features, or enhancements on existing Game: Mechanics Change Code that changes how major features work <Suggestion / Discussion> Talk it out before implementing

Comments

@mrkybe
Copy link
Contributor

mrkybe commented Mar 18, 2018 •
edited

Expected behavior

Driving fast down a road leaves smoke outside your reality bubble, but if you backtrack, that smoke shouldn't appear to still be there. It is very immersion breaking.

Actual behavior

Smoke is still there, making the existence of a reality bubble obvious to the player.

Solution

As discussed in the Discord:

@kevingranade: It looks like someone started on it at some point... fee2478
I think I'd rather we just go ahead and age the smoke.
@mrkybe mrkybe mentioned this issue Mar 18, 2018
Merged
@ZhilkinSerg ZhilkinSerg added <Enhancement / Feature> New features, or enhancements on existing Game: Mechanics Change Code that changes how major features work <Suggestion / Discussion> Talk it out before implementing labels Mar 18, 2018
@mrkybe
Copy link
Contributor Author

mrkybe commented Mar 18, 2018

Made a PR to close this: #23241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Enhancement / Feature> New features, or enhancements on existing Game: Mechanics Change Code that changes how major features work <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make smoke decay outside of the reality bubble. mrkybe/Cataclysm-DDA
2 participants
@mrkybe @ZhilkinSerg