'Could not find source vehicle for liquid transfer' (world save attached)

[zacklucky7]

Describe the bug

When trying to siphon the gasoline from a vehicle, I am given the following error message:

 DEBUG    : error in activity data: "could not find source vehicle for liquid transfer"
 
 FUNCTION : void activity_handlers::fill_liquid_do_turn(player_activity*, player*)
 FILE     : src/activity_handlers.cpp
 LINE     : 1323

This does not happen with all vehicles. I was able to siphon from a different vehicle without issue.

To Reproduce
Steps to reproduce the behavior:

1. Download the world save (version 8522, only vanilla mods)
2. Attempt to siphon from the vehicle directly south of the player character.

Expected behavior
I expected to be able to siphon gas without issue, since I could siphon gas without issue from other vehicles.

Screenshots
Screenshot of vehicle screen

Versions and configuration(please complete the following information):

• OS: Windows 10 Professional
• Game Version: 0.C-37448-ga7144d2
• Graphics version: Tiles
• Mods loaded: All mods are included with the vanilla game.

1. "dda",
2. "dda-lua",
3. "realguns",
4. "growable-pots",
5. "ew_pack",
6. "makeshift",
7. "Medieval_Stuff",
8. "More_Survival_Tools",
9. "nw_pack",
10. "modular_turrets",
11. "Salvaged_Robots",
12. "more_locations",
13. "FujiStruct",
14. "oa_additional_buildings_mod",
15. "Urban_Development",
16. "boats",
17. "deoxymod",
18. "blazemod",
19. "Tanks",
20. "necromancy",
21. "filthy_morale",
22. "no_reviving_zombies",
23. "sleepdeprivation",
24. "StatsThroughSkills"

Additional context
Download the world save (version 8522, only vanilla mods)
Screenshot of vehicle screen

I did see other (closed) issues for this issue when creating it.

[Night-Pryanik]

Closing as non-confirmed for more than a year.

[l29ah]

I can confirm it with the following save file while siphoning fuel from the semi truck:
2019.07.20-28214.zip

[l29ah]

Now cataclysm crashes when i try to load the save.

[int-ua]

Were both saves generated in an experimental build?

[OliveChukar]

Tested in ver 0.E-9072-g1bb53ba-dirty with core content pack dark days ahead only. Was not able to load save in report or the one from Apr 13, 2020. Tried spawning a truck and damaging it to match the screenshot nothing odd happened with siphoning to or from this truck with either another vehicle or a container. Need more detail or a working save to test.

[int-ua]

@zacklucky7, @l29ah, I believe you were having this issue but it looks like fixed now, please comment if it's still relevant and I'll reopen.

[Aerotinge]

I can have this issue with the current stable release 0.E-3.

 DEBUG    : error in activity data: "could not find source vehicle for liquid transfer"

 FUNCTION : void activity_handlers::fill_liquid_do_turn(player_activity*, player*)
 FILE     : src/activity_handlers.cpp
 LINE     : 1632

Versions and configuration(please complete the following information):

• OS: Windows
  • OS Version: 10.0 2009
• Game Version: 0.E-3 [64-bit]
• Graphics Version: Tiles
• Mods loaded: [
  [dda],
  [no_npc_food],
  [sees_player_retro]
  ]

To Reproduce
Steps to reproduce the behavior:

• Download the savefile
• Attempt to siphon from the vehicle(wreck) next to the player character.

Additional context
Savefile (Ellison-3)

[Night-Pryanik]

@Aerotinge could you please test it on latest experimental?

[Aerotinge]

Attempted to load old save in build#14 (17c44e4) resulting

 DEBUG    : error in activity data: "could not find source vehicle for liquid transfer"

 FUNCTION : void activity_handlers::fill_liquid_do_turn(player_activity*, player*)
 FILE     : src/activity_handlers.cpp
 LINE     : 1609

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[l29ah]

Got "could not find target vehicle for liquid transfer" on 47cbf68:
2021.11.18.zip

[cecilgol]

@l29ah try moving the vehicle - the error is caused by a null position value. i was able to reset it by moving it one tile.