Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicles roofs no longer block daylight #30509

Closed
Koalabog opened this issue May 14, 2019 · 4 comments
Closed

Vehicles roofs no longer block daylight #30509

Koalabog opened this issue May 14, 2019 · 4 comments
Labels
<Bug> This needs to be fixed (S3 - Duplicate) Bug that is duplicate of another one Vehicles Vehicles, parts, mechanics & interactions Z-levels Levels below and above ground.
Projects
Milestone

Comments

@Koalabog
Copy link

Describe the bug

Vehicle lighting no longer allows for a vehicle to be dark while it is bright outside

Steps To Reproduce

Steps to reproduce the behavior:
1.Be in an APC with curtain on its window or any other vehicle that should be dark during the day
2.It is not dark
Apparently only occurs with experimental Z-Levels on according to some quick testing on discord

Expected behavior

that a fully enclosed vehicle roofed and with no external lighting possible to be dark, assuming no internal light sources of course.

Screenshots

No internal light sources and there is a closed curtain on the window
image

Versions and configuration

  • OS: Windows [64-bit]
  • Game Version: 0.D-2912-g2ad83e9
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Weapon fixes [variousweaponfixes],(This is a small mod i made for personal use that just adds a burst fire option to UMP and makes the Mp5SD somewhat useable)
    Boats [boats]
    ]
@esotericist
Copy link
Contributor

This and some related effects (try heading into a procedurally generated house in the middle of the day) are due to the new raytracing light code (which allows light to pass through holes into deeper z-levels).

Hopefully it will be fixed soon.

@Night-Pryanik Night-Pryanik added (S1 - Need confirmation) Report waiting on confirmation of reproducibility <Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions Z-levels Levels below and above ground. labels May 14, 2019
@kevingranade
Copy link
Member

Yep my bad, this should be a bit easier to fix than the other issue at least, I just forgot to apply vehicles at all.

@kevingranade kevingranade added this to Confirmed in 0.E Release via automation Sep 6, 2019
@kevingranade kevingranade added this to the 0.E milestone Sep 6, 2019
@anothersimulacrum
Copy link
Member

anothersimulacrum commented Sep 15, 2019

I cannot reproduce this - is this still an issue?
image

@ZhilkinSerg ZhilkinSerg added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Sep 18, 2019
@ZhilkinSerg
Copy link
Contributor

Possibly duplicate of #34451

0.E Release automation moved this from Confirmed to Done Oct 8, 2019
@ZhilkinSerg ZhilkinSerg added (S3 - Duplicate) Bug that is duplicate of another one and removed (S2 - Confirmed) Bug that's been confirmed to exist labels Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed (S3 - Duplicate) Bug that is duplicate of another one Vehicles Vehicles, parts, mechanics & interactions Z-levels Levels below and above ground.
Projects
No open projects
0.E Release
  
Done
Development

No branches or pull requests

6 participants