Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Megastore errors on save load #34877

Closed
RDru opened this issue Oct 19, 2019 · 1 comment
Closed

Megastore errors on save load #34877

RDru opened this issue Oct 19, 2019 · 1 comment
Labels
<Bug> This needs to be fixed Character / World Generation Issues and enhancements concerning stages of creating a character or a world Map / Mapgen Overmap, Mapgen, Map extras, Map display (S3 - Duplicate) Bug that is duplicate of another one

Comments

@RDru
Copy link
Contributor

RDru commented Oct 19, 2019

Describe the bug

Updating from 9777 to 9778 or later, loading a save causes this errors:

DEBUG    : JSON contains circular dependency. Discarded 2 objects:
{
    "type": "overmap_terrain",
    "id": "megastore_entrance",
    "copy-from": "megastore_entrance",
    "name": "megastore",
    "sym": "M",
    "color": "i_magenta"
  },{
    "type": "overmap_terrain",
    "id": "megastore",
    "copy-from": "megastore",
    "name": "megastore",
    "sym": "m",
    "color": "i_magenta"
  },

 FUNCTION : void DynamicDataLoader::load_deferred(DynamicDataLoader::deferred_json&)
 FILE     : src/init.cpp
 LINE     : 133

DEBUG    : Loaded bad ter! ter megastore

 FUNCTION : void overmap::unserialize(std::istream&)
 FILE     : src/savegame.cpp
 LINE     : 873

Also the megastore on map becomes abandoned drive through.

Steps To Reproduce

Steps to reproduce the behavior:

  1. load a save from 9775 or before on 9778 or later with megastore on map.

Expected behavior

Stuff works.

Screenshots

Versions and configuration

Additional context

My save

@ZhilkinSerg
Copy link
Contributor

Duplicate of #34860

@ZhilkinSerg ZhilkinSerg marked this as a duplicate of #34860 Oct 19, 2019
@ZhilkinSerg ZhilkinSerg added (S3 - Duplicate) Bug that is duplicate of another one Character / World Generation Issues and enhancements concerning stages of creating a character or a world Map / Mapgen Overmap, Mapgen, Map extras, Map display <Bug> This needs to be fixed labels Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Character / World Generation Issues and enhancements concerning stages of creating a character or a world Map / Mapgen Overmap, Mapgen, Map extras, Map display (S3 - Duplicate) Bug that is duplicate of another one
Projects
None yet
Development

No branches or pull requests

2 participants