Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discolored item names in the dark. #36689

Closed
8street opened this issue Jan 4, 2020 · 7 comments
Closed

Discolored item names in the dark. #36689

8street opened this issue Jan 4, 2020 · 7 comments
Labels
Info / User Interface Game - player communication, menus, etc. Items / Item Actions / Item Qualities Items and how they work and interact <Suggestion / Discussion> Talk it out before implementing

Comments

@8street
Copy link
Contributor

8street commented Jan 4, 2020

Is your feature request related to a problem? Please describe.
In darkness, in reality, objects are not visible well enough. I can make them discolor in game. How do you like it? I myself am not sure if this is worth doing, but it will give the game more realism.

Describe the solution you'd like
Discolored item names in the very dark. All items color in the very dark becomes c_dark_gray color. In inventory, advanced inventory, pickup window, shif-v window and everywhere at all.

Code example, item.cpp:

nc_color item::color_in_inventory() const
{
    // TODO: make a const reference
    avatar &u = g->u;

    //if player in very dark then return dark color
    float light = u.fine_detail_vision_mod();
    if ( light >= 4.0f ) {
        return c_dark_gray;
    }
...

Describe alternatives you've considered
Do nothing.

Additional context
Before
dis3

After in very dark
dis4

Please comment how do you like this?

@Zireael07
Copy link
Contributor

Many characters have night vision from mutations so I assume "bad night vision" isn't a case for them.
Also I believe the colors in UI are a matter of quality-of-life, not actually seeing items?

@ZhilkinSerg
Copy link
Contributor

Yeah, I don't think that inventory is something that you look at, but something that you know you have in your posession.

@ZhilkinSerg ZhilkinSerg added <Suggestion / Discussion> Talk it out before implementing Info / User Interface Game - player communication, menus, etc. Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 4, 2020
@8street
Copy link
Contributor Author

8street commented Jan 4, 2020

Well, in the dark, the player can neither read nor craft. Why can he easily pick up items?
I agree, we don’t touch the color in the inventory, advanced inventory. But I can change the colors in the pickup and shift-v window. And of course, I will make exceptions for night vision. More opinions?

@Ulysses2
Copy link

Ulysses2 commented Jan 4, 2020

Yeah, the colored labels aren't actually representative of the item's color, but of its qualities. Like for instance, CBMs that you don't have yet are green. And it doesn't give you any information you didn't already have from the item's name, it's just a matter of convenience, so I don't see the point really.

@8street
Copy link
Contributor Author

8street commented Jan 4, 2020

dis5
Well, can still pick up items by touch. Only selected is visible. Although this is probably really overkill.

@Zireael07
Copy link
Contributor

Definitely overkill IMHO.

@8street
Copy link
Contributor Author

8street commented Jan 4, 2020

OK. The community does not need this. Closed.

@8street 8street closed this as completed Jan 4, 2020
@8street 8street changed the title [CR] Discolored item names in the dark. Discolored item names in the dark. Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info / User Interface Game - player communication, menus, etc. Items / Item Actions / Item Qualities Items and how they work and interact <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

4 participants