Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Free Merchants Broker be more specific about what he wants #46092

Closed
PaulBlay opened this issue Dec 17, 2020 · 2 comments
Closed

Make the Free Merchants Broker be more specific about what he wants #46092

PaulBlay opened this issue Dec 17, 2020 · 2 comments

Comments

@PaulBlay
Copy link

PaulBlay commented Dec 17, 2020

Is your feature request related to a problem? Please describe.

I didn't actually remember what the broker wanted for his 'food supplies'. Yes, you can ask "Who are you?" but that is not an obvious question to elicit the answer in point. I ended up opening his .json file in notepad.

Describe the solution you'd like

When you say "I'm here to deliver some food supplies." give the option to ask what exactly he wants.

Describe alternatives you've considered

Add a "What do you do here?" question.

Additional context

Change to "TALK_FREE_MERCHANT_STOCKS_DELIVER"

  {
    "type": "talk_topic",
    "id": "TALK_FREE_MERCHANT_STOCKS_DELIVER",
    "dynamic_line": "Excellent.  What've you brought us?",
    "repeat_responses": {
      "for_item": [
        "jerky",
        "meat_smoked",
        "fish_smoked",
        "dry_veggy",
        "dry_fruit",
        "cooking_oil",
        "cooking_oil2",
        "cornmeal",
        "flour",
        "fruit_wine",
        "beer",
        "sugar",
        "salt",
        "vinegar"
      ],
      "response": { "text": "Delivering <topic_item>.", "topic": "TALK_DELIVER_ASK" }
    },
    "responses": [
      { "text": "Er, what sort of goods are you looking for, again?", "topic": "TALK_FREE_MERCHANT_STOCKS_WANTED" },
      { "text": "That's all for now.  Can we discuss something else?", "topic": "TALK_NONE" },
      { "text": "That's all for now.  I'd best get going.", "topic": "TALK_DONE" }
    ]
  },

New topic "TALK_FREE_MERCHANT_STOCKS_WANTED"

  {
    "type": "talk_topic",
    "id": "TALK_FREE_MERCHANT_STOCKS_WANTED",
    "dynamic_line": {
      "gendered_line": "For now I prioritize non-perishable food, such as cornmeal, jerky, fruit wine and beer. Preferably in bulk. They are easy to locally produce in significant quantities and are non-perishable.  I'll also take any smoked fish, dehydrated fruit and vegetables you have. Basic cooking supplies like cooking oil, flour, sugar, salt and vinegar are also good.",
      "relevant_genders": [ "npc" ]
    },
    "responses": [
      { "text": "That's all for now.  Can we discuss something else?", "topic": "TALK_NONE" },
      { "text": "That's all for now.  I'd best get going.", "topic": "TALK_DONE" }
    ]
  },
@mlangsdorf
Copy link
Contributor

Your preferred option is already in the conversation;

 {
   "type": "talk_topic",
   "id": "TALK_FREE_MERCHANT_STOCKS_ALL",
   "dynamic_line": "I'm actually accepting a number of different foodstuffs: beer, sugar, flour, smoked meat, smoked fish, dried fruit and vegetables, cooking oil, preservatives like salt and vinegar; and as mentioned before, jerky, cornmeal, and fruit wine."
 },

@PaulBlay
Copy link
Author

Well, yes but as I pointed out right at the start it's hidden under the highly unintuitive "Who are you?" question tree. Which is also why I suggested adding "What do you do here?" as an alternative to my suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants