NPC can teach you bartering

[Salty-Panda]

Describe the bug

I helped an NPC, asked her to teach me, among offers was bartering

My social skill (6th lvl; 0%) didn't change

Steps To Reproduce

Complete quest, get offered to be taught bartering.

Expected behavior

Bartering should be removed from whatever lsit is used

#Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0 2004
• Game Version: 0.E-8469-ga94a537 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Aftershock [aftershock],
  Blaze Industries [blazeindustries],
  Magiclysm [magiclysm],
  Graphical Overmap [Graphical_Overmap],
  Graphical Overmap Magiclysm [Graphical_Overmap_Magiclysm],
  Mythical Martial Arts [MMA],
  C.R.I.T Expansion Mod [crt_expansion],
  No Fungal Monsters [No_Fungi],
  Stats Through Kills [stats_through_kills],
  SpeedyDex [speedydex],
  Bionic Professions [package_bionic_professions],
  Aftershock - UndeadPeople Tileset [AftershockUDP],
  Blaze Industries - UndeadPeople Tileset [BlazeIndustriesUDP],
  C.R.I.T Expansion Mod - UndeadPeople Tileset [crt_expansionUDP],
  Magiclysm - UndeadPeople Tileset [MagiclysmUDP],
  Mythical Martial Arts - UndeadPeople Tileset [MMAUDP]
  ]

[wapcaplet]

Confirmed; I recently had an NPC offer to teach lockpicking, which is also an obsoleted skill.

[actual-nh]

Was the NPC offering to teach barter a bartender, junk shopkeeper, or Jack Isherwood? They're currently down as having barter skill.

[PaulBlay]

Confirmed; I recently had an NPC offer to teach lockpicking, which is also an obsoleted skill.

Lockpicking is an obsoleted skill, but it is not an obsoleted proficiency. I'm like 50% sure I had my lockpicking proficiency increased by 12% from being taught by an NPC. (Only 50%, because I didn't check for sure I didn't have any proficiency beforehand).

Was the NPC offering to teach barter a bartender, junk shopkeeper, or Jack Isherwood? They're currently down as having barter skill.

I was offered barter training by one of those random NPCs that give you fetch quests, etc. Wesley Gary to be precise. The same guy who will endlessly walk into the side of my RV. He can also teleport, though, or he worked out how to use a lab elevator.

[Salty-Panda]

Lockpicking is an obsoleted skill, but it is not an obsoleted proficiency. I'm like 50% sure I had my lockpicking proficiency increased by 12% from being taught by an NPC. (Only 50%, because I didn't check for sure I didn't have any proficiency beforehand).

NPCs can teach skills, martial arts, spells, and proficiencies (not really, just according to code), so lockpicking may appear and work properly.

The code to get teachable skills, profs etc. is in npc.cpp : 1476, but I don't really get it.

[wapcaplet]

Here is a save game with a friendly NPC who does not have any proficiencies, yet can teach lockpicking and bartering:
teach-proficiency.zip

[Termineitor244]

Confirmed in the most recent version (Build 11451), attached save with npc offering to teach me both bartering and lockpicking.

Spartanburg.zip (Same save as in #47366 )

This world was made with a version of the game from like 3 - 4 days ago, so the npc should not be appearing with obsoleted skills.
I was going to do a different bug report, but I see it is already reported.

Edit: To clarify, this is a random npc, with the generic set of missions for random npc, she does not trains me in neither proficiency and neither she has any.

[actual-nh]

This is labeled as being for the 0.F milestone, but is not listed in the corresponding project? Thanks for the fix!