A piece of the map is not merged correctly with the rest of the map

[Scintile]

Describe the bug

A piece of the map is place in the world that doesnt connect properly to the rest of the map (English is not my first language, cant explain myself better)

Steps To Reproduce

1. Create a new character (i used Island pison layout B, got it in both attempts)
2. Reveal the map with debug
3. Find a square on the map with a few farm buildings that looks out of place
4. (Optional) download my save files. Im attaching 2 of them. One is much worse then the other - offending piece of the map cuts into the river

Expected behavior

There should be no borders like this between forests and other things

Screenshots

Screenshot

Versions and configuration

• OS: Windows 10
• Game Version: 11495
• Graphics version: Tiles
• Ingame language: English
• Mods loaded: only core game

Additional context

In both my examples part of the map that looks off is exactly the same, so im assuming its something like a Mall, but bigger and with forest. Still, it should at least not cut into the river/lake

Archive with 2 save files. Used Island prison layout B as a scenario
save.zip

[Venera3]

Hey, welcome to Isherwood farms! As you can see, it's a big chungus, and without such crap it has a real bad time spawning, barring the player from a fun mission line and some nice characters. It's a bit jarring I'll admit, but it's a compromise to make it less likely you miss out.

[Scintile]

Huh, really? Maybe then at least make sure it dosent cut into rivers?
I can forgive sloppy forest/plain borders, but when shit cuts into water - i feel compelled to spend ages editing overmap to at least try to mask it

[Venera3]

As you can see on your screenshot, it wouldn't fit if it couldn't place part of it in the water, and that leads to it bailing. That, on the other hand leads to issues about failing to generate a mission goal, and when you fought your way through a [REDACTED] full of [REDACTED] I'd rather your reward wasn't an error message. Don't get me wrong, I agree that it can come out pretty ugly but it's the lesser of two evils.

[Scintile]

Alright, then (people who disigned/made this quest line probably would cry a little) can you tell me if its possible for me to remove it from the game?

[Venera3]

data\json\overmap\overmap_specials\specials.json
You're looking for Isherwood farms, around line 1800ish. If you just want to remove the ability for it to spawn on water you can go to to the "locations" field and remove everything beside "land", if you just want to remove it wholesale replace the first value in "occurrances" with 0.

[Scintile]

Thanks! I will try that when i get back to playing cdda
I guess i will close the issue if people think its worth it to keep things they way they are right now

[NetSysFire]

I actually think there should still be some solution for this, even if this issue is low-priority.

[NetSysFire]

Since this is a lot more obvious in #56778, I reopened this. Although this is low priority, this is still something that should be fixed sometime in the future.

[NetSysFire]

Idea on how to potentially fix this: Disallow the placing of such terrain if at least one tile would occupy a river/lake associated one. That would also make them more rare, which is also a good thing since the isherwoods are seemingly everywhere.

The only thing that would remain and is much less annoying is the blocky shape, which does not fit into the natural mapgen.