Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elite zombie bio-operator disarm attack destroys items #48403

Open
Psiclops opened this issue Apr 7, 2021 · 5 comments
Open

Elite zombie bio-operator disarm attack destroys items #48403

Psiclops opened this issue Apr 7, 2021 · 5 comments
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact Monsters Monsters both friendly and unfriendly.

Comments

@Psiclops
Copy link

Psiclops commented Apr 7, 2021

When the elite zombie bio-operator "grabs your weapon and throws it to the ground", often the item is completely gone.

Steps To Reproduce

Expected behavior

By the text that happens, the item should be found on the ground nearby, but often is not.

In 3 tests, 2 out of 3 disarming moves by the elite.... cause the item to disappear.
Once was a gun, once was a melee weapon, the correctly functioning time was an identical melee weapon that did not disappear.

Screenshots

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: 0.E-10212-gb725af3 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Bionic Professions [package_bionic_professions],
    Magiclysm [magiclysm],
    Graphical Overmap [Graphical_Overmap],
    Graphical Overmap Magiclysm [Graphical_Overmap_Magiclysm]
    ]
@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact Monsters Monsters both friendly and unfriendly. labels Apr 7, 2021
@Psiclops
Copy link
Author

Psiclops commented Apr 7, 2021

Thinking back, its possible this is happening near walls, as I was in the new one level "lab" all the times it has happened.

@Zireael07
Copy link
Contributor

Hm, maybe it's trying to put the item in the wall or something weird like that?

@ZhilkinSerg
Copy link
Contributor

Yeah - there is no check for free space:

target->add_msg_if_player( m_bad, _( "and throws it to the ground!" ) );
const tripoint tp = foe->pos() + tripoint( rng( -1, 1 ), rng( -1, 1 ), 0 );
get_map().add_item_or_charges( tp, foe->i_rem( &it ) );

@actual-nh
Copy link
Contributor

Suggestion: If there isn't any free space at the randomly-selected point, put it in the square of the zombie bio-operator.

@LyleSY LyleSY added the [C++] Changes (can be) made in C++. Previously named `Code` label Dec 22, 2022
@RenechCDDA
Copy link
Contributor

No monster uses this attack anymore but mattack::bio_op_disarm is still in the code and docs, so still (vaguely) relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

No branches or pull requests

7 participants