Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limb system changes neccesary to move mutations over #51294

Open
9 of 17 tasks
Venera3 opened this issue Sep 1, 2021 · 2 comments
Open
9 of 17 tasks

Limb system changes neccesary to move mutations over #51294

Venera3 opened this issue Sep 1, 2021 · 2 comments
Labels
<Bug> This needs to be fixed Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style <Enhancement / Feature> New features, or enhancements on existing Game: Mechanics Change Code that changes how major features work Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies

Comments

@Venera3
Copy link
Member

Venera3 commented Sep 1, 2021

Migrating our mutated kinda-sorta limb traits over to the new limb system will need a lot of functionality currently missing, and a good number of variables that live in trait definitions would make more sense as limb properties. This issue is meant as a centralized wishlist/discussion of the necessary features, to keep things tidier than pestering KorGgent on Discord.

Definitely necessary for migrating mutated limbs

Not strictly speaking necessary, but logical enhancements of the system

  • Mutation attacks could probably move over to the limbs themselves, possibly with decreasing use chance on damage/derived from their scores Allow limbs to define MA techniques and unarmed damage, expand MA tech functionality #53939
  • An absolute limb volume instead of the melee weights (those can be derived from volume or overwritten by the limb def explicitly) to facilitate dynamic special attack/spell targeting and maybe feed into height/weight calculations down the line Include extra bodyparts in dodge calculations #54819
  • Moving visibility/ugliness in the limb definitions, influenced by the limb's armor coverage Allow ugliness to be defined per bodypart, allow covering up those ugly bits #55295
  • Defining mutation costs for sprouting/resorbing limbs (calories, vitamins, pain etc) - doable as it stands with EOCs
  • Limb replacement/removal defined by limb subtypes instead of explicit ID
  • Replacing/removing an arbitrary number of limbs of a given subtype to facilitate one limb turning into another
  • Utilizing anatomy definitions (anatomy_json) to define the base bodytype mutations strive towards and allowing mutation thresholds to modify the anatomy category - for a "normal" human limb mutations should be more likely to be replacements, for a posttresh Spider as long as they don't have their 8 limbs they should be more likely to gain more limbs.

Additional context

@KorGgenT @Ramza13 (touches on your character flag/bionic unhardcoding work, and EOCs could possibly be utilized in some form for some of this)

@I-am-Erk
Copy link
Member

I-am-Erk commented Sep 1, 2021

We also need to make limbs separate in sprites if we're doing this, so a sprite wouldn't just be a full skin but an arm_left, arm_right, leg_left, leg_right, torso, head, etc... Otherwise it will be very difficult to render mutations

@actual-nh actual-nh added <Bug> This needs to be fixed <Enhancement / Feature> New features, or enhancements on existing Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Game: Mechanics Change Code that changes how major features work Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Sep 1, 2021
@MylieDaniels
Copy link
Contributor

MylieDaniels commented Sep 2, 2021

Armor coverage struggles with new limbs, which cannot be covered at all presently. [EDIT: They may be covered by new clothing referencing their id, but this is not a good solution in my opinion.]
In addition, the Limbs and Armor widgets need some work, as presently:
For Limbs and other widgets that contain limb health, all limbs with a defined "hp_bar_ui_text" will attempt to display, but there is only room for 6. In compact and labels narrow, this pushes other parts of the widget around, while in classic and labels, this forces only the top 6 to display.
For Armor, only the default 5 groups can be displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style <Enhancement / Feature> New features, or enhancements on existing Game: Mechanics Change Code that changes how major features work Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

No branches or pull requests

4 participants