Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firearm repair kit can destroy tools #53378

Open
TheDarkMaster13 opened this issue Dec 11, 2021 · 6 comments
Open

Firearm repair kit can destroy tools #53378

TheDarkMaster13 opened this issue Dec 11, 2021 · 6 comments
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@TheDarkMaster13
Copy link
Contributor

Describe the bug

Assembling a firearm repair kit can result in the tools going into it being destroyed.

Steps to reproduce

  1. Repeatedly attempt to build a firearm repair kit.
  2. Eventually you will mess up and destroy a tool.

Expected behavior

The recipe is the trivial task of putting all of the tools in a box, it should not be possible to destroy any of those tools. Especially ones so rare and difficult to find and make as a hacksaw.

The firearm repair kit recipe should be impossible to fail.

Screenshots

image

Versions and configuration

  • OS: Windows
    • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
  • Game Version: 0.F-3 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Bionic Professions [package_bionic_professions],
    Aftershock [aftershock],
    No Fungal Monsters [No_Fungi]
    ]

Additional context

No response

@Fris0uman
Copy link
Contributor

firearm repair kit should go the way of the toolbox and be replaced by an empty box in which you put the tools.

@Photoloss
Copy link
Contributor

firearm repair kit should go the way of the toolbox and be replaced by an empty box in which you put the tools.

What exactly qualifies any given set of tools for repairing firearms anyway? I presume real life gunsmiths have a plethora of specialised tools to service specific brands or models but which parts are relevant for the generic "fix gun"?

On the technical side can a container/pocket check its contents as a condition for enabling an active usage action?

@wapcaplet wapcaplet added <Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Dec 12, 2021
@wapcaplet
Copy link
Contributor

There are lots of crafting recipes that specifically require the firearm repair kit. These recipes will need revision to use the particular tool qualities instead, if the kit itself will just become a box of tools.

@wapcaplet wapcaplet added the (S2 - Confirmed) Bug that's been confirmed to exist label Dec 12, 2021
@PatrikLundell
Copy link
Contributor

You're just not appreciating how inventive idiots can be in their execution of tasks:

  • I've tossed the tools into the box, but the lid won't close.
  • I've stomped on the lid, but it still won't close.
  • Take that, stupid kit! Now the lid is flush with the rest of the kit after I've run it over with my deathmobile. Hah!
  • Where are all the tools I put into the kit? Why does this always happen to me!!!

@Photoloss
Copy link
Contributor

You're just not appreciating how inventive idiots can be in their execution of tasks:

* I've tossed the tools into the box, but the lid won't close.

* I've stomped on the lid, but it still won't close.

* Take that, stupid kit! Now the lid is flush with the rest of the kit after I've run it over with my deathmobile. Hah!

* Where are all the tools I put into the kit? Why does this always happen to me!!!

Shouldn't that be a universal effect of INT<4 or so, rather than a rare oddity with the few recipes where normal failure rules don't make sense?

@PatrikLundell
Copy link
Contributor

If this was Fallout (the RPG, not the Oblivion with Guns FPS ripoff), definitely. I don't think it would be appreciated in a roguelike, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

5 participants